Move the entire audit subsystem (system audit, API audit, import audit, user lifecycle audit, frontend telemetry) from core into modules/audit/. Core decoupling via interface-based injection: - AuditRecorderInterface replaces SystemAuditService in 10+ core services - UserLifecycleAuditInterface / ImportAuditInterface for specialized flows - NullAuditRecorder fallback when audit module is disabled - ApiBootstrap/ApiResponse use null-safe callable resolvers Module structure (modules/audit/): - Manifest with routes, permissions, scheduler jobs, authorization policy - 9 services, 8 repositories, 6 domain enums, 4 job handlers - 33 page files, 4 JS files, 8 test files, migration scripts, i18n Core cleanup: - OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService surgically cleaned of audit-specific constants - Sidebar template cleared of hardcoded audit navigation - AuditModuleIsolationContractTest ensures no future core→module coupling All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5 clean, architecture contracts verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
75 lines
3.1 KiB
PHP
75 lines
3.1 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class ListUiSharedPartialsContractTest extends TestCase
|
|
{
|
|
use ProjectFileAssertionSupport;
|
|
|
|
/**
|
|
* @return list<string>
|
|
*/
|
|
private function listTabsTemplateFiles(): array
|
|
{
|
|
return [
|
|
'pages/admin/users/index(default).phtml',
|
|
'pages/admin/departments/index(default).phtml',
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return list<string>
|
|
*/
|
|
private function purgeTitlebarTemplateFiles(): array
|
|
{
|
|
return [
|
|
'pages/admin/scheduled-jobs/index(default).phtml',
|
|
'modules/audit/pages/admin/api-audit/index(default).phtml',
|
|
'modules/audit/pages/admin/import-audit/index(default).phtml',
|
|
'modules/audit/pages/admin/user-lifecycle-audit/index(default).phtml',
|
|
'modules/audit/pages/admin/system-audit/index(default).phtml',
|
|
];
|
|
}
|
|
|
|
public function testTabsTemplatesUseSharedTabsPartial(): void
|
|
{
|
|
foreach ($this->listTabsTemplateFiles() as $file) {
|
|
$content = $this->readProjectFile($file);
|
|
$this->assertStringContainsString("require templatePath('partials/app-list-tabs.phtml');", $content, $file);
|
|
$this->assertSame(0, preg_match('/<div\s+class=\"app-list-tabs\"/', $content), $file);
|
|
}
|
|
}
|
|
|
|
public function testPurgeTitlebarTemplatesUseSharedPurgePartial(): void
|
|
{
|
|
foreach ($this->purgeTitlebarTemplateFiles() as $file) {
|
|
$content = $this->readProjectFile($file);
|
|
$this->assertStringContainsString("require templatePath('partials/app-list-purge-action.phtml');", $content, $file);
|
|
$this->assertSame(0, preg_match('/<form\s+id=\"[^\"]*purge-form\"/', $content), $file);
|
|
$this->assertStringNotContainsString('onclick="return confirm(\'', $content, $file);
|
|
}
|
|
}
|
|
|
|
public function testTabsAndPurgePartialsExposeExpectedMarkupContract(): void
|
|
{
|
|
$tabsPartial = $this->readProjectFile('templates/partials/app-list-tabs.phtml');
|
|
$this->assertStringContainsString('class="app-list-tabs"', $tabsPartial);
|
|
$this->assertStringContainsString("class=\"<?php e(\$tabActive ? 'tab-link is-active' : 'tab-link'); ?>\"", $tabsPartial);
|
|
|
|
$purgePartial = $this->readProjectFile('templates/partials/app-list-purge-action.phtml');
|
|
$this->assertStringContainsString('method="post"', $purgePartial);
|
|
$this->assertStringContainsString('Session::getCsrfInput();', $purgePartial);
|
|
$this->assertStringContainsString('data-confirm-message="<?php e($listPurgeConfirmMessage); ?>"', $purgePartial);
|
|
$this->assertStringNotContainsString('onclick="return confirm(\'', $purgePartial);
|
|
}
|
|
|
|
public function testAppInitIncludesGlobalConfirmActionComponent(): void
|
|
{
|
|
$content = $this->readProjectFile('web/js/app-init.js');
|
|
$this->assertStringContainsString("import { initConfirmActions } from './components/app-confirm-actions.js';", $content);
|
|
$this->assertStringContainsString("runtime.register('confirm-actions', initConfirmActions", $content);
|
|
}
|
|
}
|