2026-03-04 15:56:58 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
|
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
|
|
|
|
|
|
class ListUiSharedPartialsContractTest extends TestCase
|
|
|
|
|
{
|
|
|
|
|
use ProjectFileAssertionSupport;
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @return list<string>
|
|
|
|
|
*/
|
|
|
|
|
private function listTabsTemplateFiles(): array
|
|
|
|
|
{
|
|
|
|
|
return [
|
|
|
|
|
'pages/admin/users/index(default).phtml',
|
|
|
|
|
'pages/admin/departments/index(default).phtml',
|
|
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @return list<string>
|
|
|
|
|
*/
|
|
|
|
|
private function purgeTitlebarTemplateFiles(): array
|
|
|
|
|
{
|
|
|
|
|
return [
|
|
|
|
|
'pages/admin/scheduled-jobs/index(default).phtml',
|
refactor(audit): extract audit domain into self-contained module
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.
Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers
Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n
Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling
All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
|
|
|
'modules/audit/pages/admin/api-audit/index(default).phtml',
|
|
|
|
|
'modules/audit/pages/admin/import-audit/index(default).phtml',
|
|
|
|
|
'modules/audit/pages/admin/user-lifecycle-audit/index(default).phtml',
|
|
|
|
|
'modules/audit/pages/admin/system-audit/index(default).phtml',
|
2026-03-04 15:56:58 +01:00
|
|
|
];
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testTabsTemplatesUseSharedTabsPartial(): void
|
|
|
|
|
{
|
|
|
|
|
foreach ($this->listTabsTemplateFiles() as $file) {
|
|
|
|
|
$content = $this->readProjectFile($file);
|
|
|
|
|
$this->assertStringContainsString("require templatePath('partials/app-list-tabs.phtml');", $content, $file);
|
|
|
|
|
$this->assertSame(0, preg_match('/<div\s+class=\"app-list-tabs\"/', $content), $file);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testPurgeTitlebarTemplatesUseSharedPurgePartial(): void
|
|
|
|
|
{
|
|
|
|
|
foreach ($this->purgeTitlebarTemplateFiles() as $file) {
|
|
|
|
|
$content = $this->readProjectFile($file);
|
|
|
|
|
$this->assertStringContainsString("require templatePath('partials/app-list-purge-action.phtml');", $content, $file);
|
|
|
|
|
$this->assertSame(0, preg_match('/<form\s+id=\"[^\"]*purge-form\"/', $content), $file);
|
|
|
|
|
$this->assertStringNotContainsString('onclick="return confirm(\'', $content, $file);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testTabsAndPurgePartialsExposeExpectedMarkupContract(): void
|
|
|
|
|
{
|
|
|
|
|
$tabsPartial = $this->readProjectFile('templates/partials/app-list-tabs.phtml');
|
|
|
|
|
$this->assertStringContainsString('class="app-list-tabs"', $tabsPartial);
|
|
|
|
|
$this->assertStringContainsString("class=\"<?php e(\$tabActive ? 'tab-link is-active' : 'tab-link'); ?>\"", $tabsPartial);
|
|
|
|
|
|
|
|
|
|
$purgePartial = $this->readProjectFile('templates/partials/app-list-purge-action.phtml');
|
|
|
|
|
$this->assertStringContainsString('method="post"', $purgePartial);
|
|
|
|
|
$this->assertStringContainsString('Session::getCsrfInput();', $purgePartial);
|
|
|
|
|
$this->assertStringContainsString('data-confirm-message="<?php e($listPurgeConfirmMessage); ?>"', $purgePartial);
|
|
|
|
|
$this->assertStringNotContainsString('onclick="return confirm(\'', $purgePartial);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function testAppInitIncludesGlobalConfirmActionComponent(): void
|
|
|
|
|
{
|
|
|
|
|
$content = $this->readProjectFile('web/js/app-init.js');
|
feat: extend module platform with UI slots, runtime components, CLI tooling and {{userId}} search support
Completes the generic module platform that enables modules to contribute
UI elements, runtime JS components, and search resources without any
core hardcoding.
New generic UI slot types:
- topbar.right_item: module-contributed topbar buttons
- layout.body_end_template: module-contributed dialog/overlay templates
- layout.head_style: module-contributed global CSS
- runtime.component: declarative JS component registration with phase ordering
New infrastructure:
- ModuleAutoloader: PSR-4 autoloading for module-local PHP classes
- ModuleRuntimePageBuilder: symlinks module pages into runtime directory
- ModuleRuntimeAssetPublisher: publishes module CSS/JS to web/modules/
- ModulePermissionSynchronizer: syncs module permissions to DB
- CLI scripts: module-runtime-sync, module-build, module-migrate,
module-permissions-sync, module-assets-sync
- {{userId}} placeholder in SearchDataService for user-scoped search queries
- Component runtime with phased initialization (early/default/late)
- AppContainer.protectExistingBindings() to prevent module→core overwrites
- Architecture tests: ModuleStructureContractTest, CoreTemplateIsolationTest,
FrontendComponentRuntimeContractTest, AppContainerIsolationContractTest
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-18 22:19:56 +01:00
|
|
|
$this->assertStringContainsString("import { initConfirmActions } from './components/app-confirm-actions.js';", $content);
|
|
|
|
|
$this->assertStringContainsString("runtime.register('confirm-actions', initConfirmActions", $content);
|
2026-03-04 15:56:58 +01:00
|
|
|
}
|
|
|
|
|
}
|