1
0
Files
breadcrumb-the-shire/core/Http/RequestRuntime.php
fs 3f0db68b27 refactor: fix all 105 PHPStan 2 strict type findings across core and modules
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline
from 486 to 382 entries (only unused-public false positives remain).

Categories fixed:
- Remove 39 redundant type checks (is_string, is_array, is_object, method_exists)
- Remove 12 no-op array_values() on already-sequential lists
- Simplify 13 null-coalesce on guaranteed offsets
- Remove 8 always-true instanceof checks
- Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount)
- Simplify 6 unnecessary nullsafe operators (?-> → ->)
- Fix 6 always-true !== '' comparisons
- Fix remaining: unset.offset, return.unusedType, staticMethod narrowing

53 files changed across core/, modules/, pages/, and tests/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-14 12:54:20 +02:00

67 lines
1.5 KiB
PHP

<?php
namespace MintyPHP\Http;
class RequestRuntime implements RequestRuntimeInterface
{
public function method(): string
{
$method = strtoupper(trim((string) ($this->context()['method'] ?? '')));
if ($method === '') {
return 'GET';
}
return substr($method, 0, 8);
}
public function path(): string
{
return trim((string) ($this->context()['path'] ?? ''));
}
public function ip(): string
{
return trim((string) ($this->context()['ip'] ?? ''));
}
public function userAgent(): string
{
return trim((string) ($this->context()['user_agent'] ?? ''));
}
/**
* @return array<string, mixed>
*/
public function queryParams(): array
{
/** @var array<string, mixed> $query */
$query = $_GET;
return $query;
}
public function isSecure(): bool
{
$https = strtolower(trim((string) ($_SERVER['HTTPS'] ?? '')));
if (in_array($https, ['on', '1', 'true'], true)) {
return true;
}
$forwarded = strtolower(trim((string) ($_SERVER['HTTP_X_FORWARDED_PROTO'] ?? '')));
if ($forwarded === '') {
return false;
}
$parts = explode(',', $forwarded);
return trim($parts[0]) === 'https';
}
/**
* @return array<string, mixed>
*/
private function context(): array
{
RequestContext::ensureStarted();
return RequestContext::context();
}
}