tbh/breadcrumb-the-shire
1
0
Fork 0
forked from fa/breadcrumb-the-shire
Code Pull Requests Activity

Split detail action policy contracts

Browse Source
This commit is contained in:
Felix Schneider
2026-03-19 19:03:10 +01:00
parent cc653cb4cd
commit f6046c9168
7 changed files with 102 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
phpunit.xml
View File

@@ -50,7 +50,9 @@
<file>tests/Architecture/AuthzUiActionContractTest.php</file>
<file>tests/Architecture/AuthzUiLayoutContractTest.php</file>
<file>tests/Architecture/AuthzUiTemplateContractTest.php</file>
<file>tests/Architecture/DetailActionPolicyContractTest.php</file>
<file>tests/Architecture/DetailActionPolicyMigrationContractTest.php</file>
<file>tests/Architecture/DetailActionPolicyPartialContractTest.php</file>
<file>tests/Architecture/DetailActionPolicyRuntimeContractTest.php</file>
<file>tests/Architecture/DetailPageContractTest.php</file>
<file>tests/Architecture/DetailValidationActionContractTest.php</file>
<file>tests/Architecture/DetailValidationAssetContractTest.php</file>

25
tests/Architecture/DetailActionPolicyContractFiles.php Normal file
View File

@@ -0,0 +1,25 @@
<?php
namespace MintyPHP\Tests\Architecture;
final class DetailActionPolicyContractFiles
{
/**
* @return list<string>
*/
public static function migratedConfirmFiles(): array
{
return [
'pages/admin/users/edit(default).phtml',
'pages/admin/users/_form.phtml',
'pages/admin/tenants/edit(default).phtml',
'pages/admin/tenants/_form.phtml',
'pages/admin/departments/edit(default).phtml',
'pages/admin/roles/edit(default).phtml',
'pages/admin/permissions/edit(default).phtml',
'pages/admin/settings/index(default).phtml',
'templates/partials/app-details-titlebar.phtml',
'templates/partials/app-details-aside-actions.phtml',
];
}
}

68
tests/Architecture/DetailActionPolicyContractTest.php
View File

@@ -1,68 +0,0 @@
<?php
namespace MintyPHP\Tests\Architecture;
use PHPUnit\Framework\TestCase;
class DetailActionPolicyContractTest extends TestCase
{
use ProjectFileAssertionSupport;
/**
* @return list<string>
*/
private function migratedConfirmFiles(): array
{
return [
'pages/admin/users/edit(default).phtml',
'pages/admin/users/_form.phtml',
'pages/admin/tenants/edit(default).phtml',
'pages/admin/tenants/_form.phtml',
'pages/admin/departments/edit(default).phtml',
'pages/admin/roles/edit(default).phtml',
'pages/admin/permissions/edit(default).phtml',
'pages/admin/settings/index(default).phtml',
'templates/partials/app-details-titlebar.phtml',
'templates/partials/app-details-aside-actions.phtml',
];
}
public function testDetailPageFactoryUsesActionPolicyModule(): void
{
$content = $this->readProjectFile('web/js/core/app-detail-page-factory.js');
$this->assertStringContainsString("import { initDetailActionPolicy } from './app-details-action-policy.js';", $content);
$this->assertStringContainsString('const actionPolicy = initDetailActionPolicy(', $content);
$this->assertStringContainsString('actionPolicy.isSubmitting()', $content);
}
public function testDetailsPartialsExposeActionPolicyContract(): void
{
$titlebar = $this->readProjectFile('templates/partials/app-details-titlebar.phtml');
$this->assertStringContainsString('data-detail-action-policy="1"', $titlebar);
$this->assertStringContainsString('data-detail-action-kind=', $titlebar);
$this->assertStringContainsString('data-detail-confirm-message=', $titlebar);
$asideActions = $this->readProjectFile('templates/partials/app-details-aside-actions.phtml');
$this->assertStringContainsString('data-detail-confirm-message=', $asideActions);
$danger = $this->readProjectFile('templates/partials/app-danger-zone-delete-field.phtml');
$this->assertStringContainsString('data-detail-action-kind="delete"', $danger);
}
public function testMigratedFilesNoLongerUseInlineConfirmHandlers(): void
{
foreach ($this->migratedConfirmFiles() as $file) {
$content = $this->readProjectFile($file);
$this->assertStringNotContainsString('onsubmit="return confirm(', $content, $file);
$this->assertStringNotContainsString('onclick="return confirm(', $content, $file);
}
}
public function testMigratedFilesExposeDataDetailConfirmContract(): void
{
foreach ($this->migratedConfirmFiles() as $file) {
$content = $this->readProjectFile($file);
$this->assertStringContainsString('data-detail-confirm-message', $content, $file);
}
}
}

27
tests/Architecture/DetailActionPolicyMigrationContractTest.php Normal file
View File

@@ -0,0 +1,27 @@
<?php
namespace MintyPHP\Tests\Architecture;
use PHPUnit\Framework\TestCase;
final class DetailActionPolicyMigrationContractTest extends TestCase
{
use ProjectFileAssertionSupport;
public function testMigratedFilesNoLongerUseInlineConfirmHandlers(): void
{
foreach (DetailActionPolicyContractFiles::migratedConfirmFiles() as $file) {
$content = $this->readProjectFile($file);
$this->assertStringNotContainsString('onsubmit="return confirm(', $content, $file);
$this->assertStringNotContainsString('onclick="return confirm(', $content, $file);
}
}
public function testMigratedFilesExposeDataDetailConfirmContract(): void
{
foreach (DetailActionPolicyContractFiles::migratedConfirmFiles() as $file) {
$content = $this->readProjectFile($file);
$this->assertStringContainsString('data-detail-confirm-message', $content, $file);
}
}
}

24
tests/Architecture/DetailActionPolicyPartialContractTest.php Normal file
View File

@@ -0,0 +1,24 @@
<?php
namespace MintyPHP\Tests\Architecture;
use PHPUnit\Framework\TestCase;
final class DetailActionPolicyPartialContractTest extends TestCase
{
use ProjectFileAssertionSupport;
public function testDetailsPartialsExposeActionPolicyContract(): void
{
$titlebar = $this->readProjectFile('templates/partials/app-details-titlebar.phtml');
$this->assertStringContainsString('data-detail-action-policy="1"', $titlebar);
$this->assertStringContainsString('data-detail-action-kind=', $titlebar);
$this->assertStringContainsString('data-detail-confirm-message=', $titlebar);
$asideActions = $this->readProjectFile('templates/partials/app-details-aside-actions.phtml');
$this->assertStringContainsString('data-detail-confirm-message=', $asideActions);
$danger = $this->readProjectFile('templates/partials/app-danger-zone-delete-field.phtml');
$this->assertStringContainsString('data-detail-action-kind="delete"', $danger);
}
}

22
tests/Architecture/DetailActionPolicyRuntimeContractTest.php Normal file
View File

@@ -0,0 +1,22 @@
<?php
namespace MintyPHP\Tests\Architecture;
use PHPUnit\Framework\TestCase;
final class DetailActionPolicyRuntimeContractTest extends TestCase
{
use ProjectFileAssertionSupport;
public function testDetailPageFactoryUsesActionPolicyModule(): void
{
$content = $this->readProjectFile('web/js/core/app-detail-page-factory.js');
$this->assertStringContainsString(
"import { initDetailActionPolicy } from './app-details-action-policy.js';",
$content
);
$this->assertStringContainsString('const actionPolicy = initDetailActionPolicy(', $content);
$this->assertStringContainsString('actionPolicy.isSubmitting()', $content);
}
}

2
tests/README.md
View File

@@ -32,7 +32,7 @@ ohne dass jede Aenderung immer die komplette Suite im Kopf behalten muss.
## Naechste Refactor-Kandidaten
- `tests/Architecture/DetailActionPolicyContractTest.php`
- `tests/Architecture/ContainerFactoryContractTest.php`
- `tests/Architecture/SecurityLoggingContractTest.php`
- `tests/Architecture/StatusTaxonomyContractTest.php`
- `tests/Architecture/DetailPageContractTest.php`