tbh/breadcrumb-the-shire
1
0
Fork 0
forked from fa/breadcrumb-the-shire
Code Pull Requests Activity

refactor: remove redundant null-coalescing and type checks in UserAccountService

Browse Source 
Values are already guaranteed by the repository layer, so defensive
guards like ?? 0, ?? '' and is_array() are unnecessary.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-22 14:15:29 +01:00
parent e24af62a59
commit ae392d55e8
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Service/User/UserAccountService.php
View File

@@ -192,11 +192,11 @@ class UserAccountService
foreach ($deletedUsers as $deletedUser) {
$this->eventDispatcher?->dispatch('user.deleted', [
'user_id' => (int) ($deletedUser['id'] ?? 0),
'uuid' => (string) ($deletedUser['uuid'] ?? ''),
'user_id' => (int) $deletedUser['id'],
'uuid' => (string) $deletedUser['uuid'],
'actor_user_id' => $currentUserId,
'display_name' => (string) ($deletedUser['display_name'] ?? ''),
'tenant_ids' => is_array($deletedUser['tenant_ids'] ?? null) ? $deletedUser['tenant_ids'] : [],
'display_name' => (string) $deletedUser['display_name'],
'tenant_ids' => $deletedUser['tenant_ids'],
]);
}
@@ -579,7 +579,7 @@ class UserAccountService
continue;
}
$targetUserId = (int) ($user['id'] ?? 0);
$targetUserId = (int) $user['id'];
if ($targetUserId <= 0) {
continue;
}
@@ -843,7 +843,7 @@ class UserAccountService
private function safeAssignmentsForUser(int $userId): array
{
$assignments = $this->userAssignmentService->buildAssignmentsForUser($userId);
return is_array($assignments) ? $assignments : [];
return $assignments;
}
private function extractAssignmentIds(array $assignments, string $key): array