tbh/breadcrumb-the-shire
1
0
Fork 0
forked from fa/breadcrumb-the-shire
Code Pull Requests Activity

refactor: enforce layer discipline — move repositories, fix constructor injection

Browse Source 
- Move HelpdeskTenantSettingsRepository and HelpdeskTokenRepository from
  Service/ to Repository/ directory (GR-SEC-003: SQL only in repositories)
- Make AccessControl constructor require IntendedUrlService explicitly
  instead of falling back to `new IntendedUrlService()` (GR-TEST-002:
  no service instantiation outside factories)
- Update all imports and tests accordingly

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-13 19:28:07 +02:00
parent a17c2c7cea
commit 4e6b586b77
10 changed files with 21 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Http/AccessControlTest.php
View File

@@ -3,13 +3,19 @@
namespace MintyPHP\Tests\Http;
use MintyPHP\Http\AccessControl;
use MintyPHP\Http\IntendedUrlService;
use PHPUnit\Framework\TestCase;
class AccessControlTest extends TestCase
{
private function createAccessControl(array $publicPaths = []): AccessControl
{
return new AccessControl($publicPaths, new IntendedUrlService());
}
public function testConfiguredPublicPathIsAccessible(): void
{
$accessControl = new AccessControl(['imprint', 'privacy']);
$accessControl = $this->createAccessControl(['imprint', 'privacy']);
$this->assertTrue($accessControl->isPublicPath('imprint'));
$this->assertTrue($accessControl->isPublicPath('/privacy'));
@@ -17,7 +23,7 @@ class AccessControlTest extends TestCase
public function testPageSlugPathIsNotAutoPublic(): void
{
$accessControl = new AccessControl(['imprint']);
$accessControl = $this->createAccessControl(['imprint']);
$this->assertTrue($accessControl->isPublicPath('imprint'));
$this->assertFalse($accessControl->isPublicPath('page/imprint'));
@@ -25,7 +31,7 @@ class AccessControlTest extends TestCase
public function testAlwaysPublicPrefixesRemainAccessible(): void
{
$accessControl = new AccessControl([]);
$accessControl = $this->createAccessControl([]);
$this->assertTrue($accessControl->isPublicPath('api/v1/health'));
$this->assertTrue($accessControl->isPublicPath('auth/microsoft/callback'));