diff --git a/lib/Http/AccessControl.php b/lib/Http/AccessControl.php index a73cd03..47b2a66 100644 --- a/lib/Http/AccessControl.php +++ b/lib/Http/AccessControl.php @@ -22,7 +22,7 @@ class AccessControl private array $configuredPublicPaths; private IntendedUrlService $intendedUrlService; - public function __construct(array $publicPaths = [], ?IntendedUrlService $intendedUrlService = null) + public function __construct(array $publicPaths, IntendedUrlService $intendedUrlService) { $normalizedPaths = []; foreach ($publicPaths as $path) { @@ -34,7 +34,7 @@ class AccessControl } $this->configuredPublicPaths = array_values(array_unique($normalizedPaths)); - $this->intendedUrlService = $intendedUrlService ?? new IntendedUrlService(); + $this->intendedUrlService = $intendedUrlService; } /** diff --git a/modules/helpdesk/lib/Module/Helpdesk/HelpdeskContainerRegistrar.php b/modules/helpdesk/lib/Module/Helpdesk/HelpdeskContainerRegistrar.php index 3c11312..e74126b 100644 --- a/modules/helpdesk/lib/Module/Helpdesk/HelpdeskContainerRegistrar.php +++ b/modules/helpdesk/lib/Module/Helpdesk/HelpdeskContainerRegistrar.php @@ -13,8 +13,8 @@ use MintyPHP\Module\Helpdesk\Service\EffectiveHelpdeskSettingsService; use MintyPHP\Module\Helpdesk\Service\HelpdeskOAuthTokenService; use MintyPHP\Module\Helpdesk\Service\HelpdeskSettingsGateway; use MintyPHP\Module\Helpdesk\Service\HelpdeskTenantSettingsGateway; -use MintyPHP\Module\Helpdesk\Service\HelpdeskTenantSettingsRepository; -use MintyPHP\Module\Helpdesk\Service\HelpdeskTokenRepository; +use MintyPHP\Module\Helpdesk\Repository\HelpdeskTenantSettingsRepository; +use MintyPHP\Module\Helpdesk\Repository\HelpdeskTokenRepository; use MintyPHP\Module\Helpdesk\Service\SystemRecommendationEngine; use MintyPHP\Module\Helpdesk\Service\TicketCommunicationService; use MintyPHP\Service\Access\PermissionService; diff --git a/modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsRepository.php b/modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTenantSettingsRepository.php similarity index 98% rename from modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsRepository.php rename to modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTenantSettingsRepository.php index f7047f9..d950f09 100644 --- a/modules/helpdesk/lib/Module/Helpdesk/Service/HelpdeskTenantSettingsRepository.php +++ b/modules/helpdesk/lib/Module/Helpdesk/Repository/HelpdeskTenantSettingsRepository.php @@ -1,6 +1,6 @@ createAccessControl(['imprint', 'privacy']); $this->assertTrue($accessControl->isPublicPath('imprint')); $this->assertTrue($accessControl->isPublicPath('/privacy')); @@ -17,7 +23,7 @@ class AccessControlTest extends TestCase public function testPageSlugPathIsNotAutoPublic(): void { - $accessControl = new AccessControl(['imprint']); + $accessControl = $this->createAccessControl(['imprint']); $this->assertTrue($accessControl->isPublicPath('imprint')); $this->assertFalse($accessControl->isPublicPath('page/imprint')); @@ -25,7 +31,7 @@ class AccessControlTest extends TestCase public function testAlwaysPublicPrefixesRemainAccessible(): void { - $accessControl = new AccessControl([]); + $accessControl = $this->createAccessControl([]); $this->assertTrue($accessControl->isPublicPath('api/v1/health')); $this->assertTrue($accessControl->isPublicPath('auth/microsoft/callback'));