tbh/breadcrumb-the-shire
1
0
Fork 0
forked from fa/breadcrumb-the-shire
Code Pull Requests Activity

fix(helpdesk): extract SOAP fault detail from GetTicketFile error responses

Browse Source 
Show the actual BC error message instead of just 'HTTP 500' to help
diagnose authentication and parameter issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-05 22:55:12 +02:00
parent c2eba3e671
commit 2b2f41ebab
1 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
modules/helpdesk/lib/Module/Helpdesk/Service/BcSoapGateway.php
View File

@@ -335,7 +335,10 @@ XML;
$httpCode = (int) ($response['http_code'] ?? 0);
$rawBody = (string) ($response['body'] ?? '');
if ($httpCode < 200 || $httpCode >= 300) {
return ['ok' => false, 'error' => 'SOAP request failed: HTTP ' . $httpCode];
// Try to extract SOAP fault from error response body
$faultDetail = $this->extractSoapFault($rawBody);
return ['ok' => false, 'error' => 'SOAP request failed: HTTP ' . $httpCode . ($faultDetail !== '' ? ' — ' . $faultDetail : '')];
}
return $this->parseGetTicketFileResponse($rawBody);
@@ -423,6 +426,30 @@ XML;
return ['ok' => true, 'data' => $decoded];
}
private function extractSoapFault(string $body): string
{
if ($body === '') {
return '';
}
$dom = new \DOMDocument();
$prev = libxml_use_internal_errors(true);
$loaded = $dom->loadXML($body);
libxml_clear_errors();
libxml_use_internal_errors($prev);
if (!$loaded) {
return mb_substr(trim($body), 0, 200);
}
$xpath = new \DOMXPath($dom);
$faultNode = $xpath->query("//*[local-name()='Fault']/*[local-name()='faultstring']")->item(0);
if ($faultNode instanceof \DOMNode) {
return trim((string) $faultNode->textContent);
}
return mb_substr(trim($body), 0, 200);
}
private function buildSoapEndpoint(): ?string
{
$baseUrl = trim($this->settingsGateway->getODataBaseUrl());