fs
f403a6704f
Extract findPatternMatchesIn*Files() to ProjectFileAssertionSupport trait for reuse. Add contract tests for: - GR-SEC-005: Encryption centralized in Crypto.php - GR-SEC-006: File storage in storage/, not web/ - GR-SEC-002: No PII in error_log() calls - GR-CORE-012: POST-Redirect-GET pattern enforcement - GR-UI-015: i18n key completeness de ↔ en Brings automated guard coverage from 24 to 29 test files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
92 lines
2.8 KiB
PHP
92 lines
2.8 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
use RecursiveDirectoryIterator;
|
|
use RecursiveIteratorIterator;
|
|
|
|
/**
|
|
* GR-SEC-002: No PII or secrets in error_log() calls.
|
|
* Scans for error_log() calls that interpolate variables likely containing
|
|
* personal data or credentials.
|
|
*/
|
|
class SecurityLoggingContractTest extends TestCase
|
|
{
|
|
use ProjectFileAssertionSupport;
|
|
|
|
/** Variable names that strongly suggest PII or secret content. */
|
|
private const PII_VARIABLE_PATTERNS = [
|
|
'/\$email\b/',
|
|
'/\$password\b/',
|
|
'/\$passwort\b/',
|
|
'/\$token\b/',
|
|
'/\$secret\b/',
|
|
'/\$apiKey\b/',
|
|
'/\$cryptoKey\b/',
|
|
'/\$creditCard\b/',
|
|
'/\$sessionId\b/',
|
|
'/\$firstName\b/',
|
|
'/\$lastName\b/',
|
|
'/\$phone\b/',
|
|
'/\$ssn\b/',
|
|
];
|
|
|
|
public function testNoErrorLogCallsContainPiiVariables(): void
|
|
{
|
|
$root = $this->projectRootPath();
|
|
$violations = [];
|
|
|
|
foreach (['lib', 'pages'] as $dir) {
|
|
$basePath = $root . '/' . $dir;
|
|
$iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($basePath));
|
|
|
|
/** @var \SplFileInfo $file */
|
|
foreach ($iterator as $file) {
|
|
if (!$file->isFile() || $file->getExtension() !== 'php') {
|
|
continue;
|
|
}
|
|
|
|
$content = (string) file_get_contents($file->getPathname());
|
|
$relativePath = str_replace($root . '/', '', $file->getPathname());
|
|
|
|
if (preg_match_all('/^.*\berror_log\s*\(.*$/m', $content, $matches)) {
|
|
foreach ($matches[0] as $line) {
|
|
foreach (self::PII_VARIABLE_PATTERNS as $piiPattern) {
|
|
if (preg_match($piiPattern, $line)) {
|
|
$violations[] = $relativePath . ': ' . trim($line);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
sort($violations);
|
|
|
|
$this->assertSame(
|
|
[],
|
|
$violations,
|
|
"error_log() calls with potential PII variables (GR-SEC-002):\n" . implode("\n", $violations)
|
|
);
|
|
}
|
|
|
|
public function testErrorLogUsageIsMinimal(): void
|
|
{
|
|
$violations = array_merge(
|
|
$this->findPatternMatchesInPhpFiles('lib', '/\berror_log\s*\(/'),
|
|
$this->findPatternMatchesInPhpFiles('pages', '/\berror_log\s*\(/')
|
|
);
|
|
$violations = array_values(array_unique($violations));
|
|
sort($violations);
|
|
|
|
$this->assertLessThanOrEqual(
|
|
3,
|
|
count($violations),
|
|
"error_log() usage growing — consider structured logging (GR-SEC-002). Found in:\n"
|
|
. implode("\n", $violations)
|
|
);
|
|
}
|
|
}
|