fs
3f0db68b27
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline from 486 to 382 entries (only unused-public false positives remain). Categories fixed: - Remove 39 redundant type checks (is_string, is_array, is_object, method_exists) - Remove 12 no-op array_values() on already-sequential lists - Simplify 13 null-coalesce on guaranteed offsets - Remove 8 always-true instanceof checks - Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount) - Simplify 6 unnecessary nullsafe operators (?-> → ->) - Fix 6 always-true !== '' comparisons - Fix remaining: unset.offset, return.unusedType, staticMethod narrowing 53 files changed across core/, modules/, pages/, and tests/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
71 lines
1.8 KiB
PHP
71 lines
1.8 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Support;
|
|
|
|
use MintyPHP\App\AppContainer;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class AppContainerIsolationTraitTest extends TestCase
|
|
{
|
|
public function testPushAndRestoreRoundTripKeepsOriginalGlobalContainer(): void
|
|
{
|
|
$original = $GLOBALS['minty_app_container'];
|
|
self::assertInstanceOf(AppContainer::class, $original);
|
|
|
|
$harness = new class () {
|
|
use AppContainerIsolationTrait;
|
|
|
|
public function push(AppContainer $container): void
|
|
{
|
|
$this->pushAppContainer($container);
|
|
}
|
|
|
|
public function restore(): void
|
|
{
|
|
$this->restoreAppContainer();
|
|
}
|
|
};
|
|
|
|
$replacement = new AppContainer();
|
|
$harness->push($replacement);
|
|
|
|
self::assertSame($replacement, $GLOBALS['minty_app_container']);
|
|
|
|
$harness->restore();
|
|
|
|
self::assertSame($original, $GLOBALS['minty_app_container']);
|
|
}
|
|
|
|
public function testMultiplePushesRestoreToInitialContainer(): void
|
|
{
|
|
$original = $GLOBALS['minty_app_container'];
|
|
self::assertInstanceOf(AppContainer::class, $original);
|
|
|
|
$harness = new class () {
|
|
use AppContainerIsolationTrait;
|
|
|
|
public function push(AppContainer $container): void
|
|
{
|
|
$this->pushAppContainer($container);
|
|
}
|
|
|
|
public function restore(): void
|
|
{
|
|
$this->restoreAppContainer();
|
|
}
|
|
};
|
|
|
|
$first = new AppContainer();
|
|
$second = new AppContainer();
|
|
|
|
$harness->push($first);
|
|
$harness->push($second);
|
|
|
|
self::assertSame($second, $GLOBALS['minty_app_container']);
|
|
|
|
$harness->restore();
|
|
|
|
self::assertSame($original, $GLOBALS['minty_app_container']);
|
|
}
|
|
}
|