Files
breadcrumb-the-shire/tests/Architecture/AuditModuleIsolationContractTest.php
fs 7a222f0b1f fix(audit): harden module isolation and fix post-extraction drift
Fix 5 broken FQCN references (runtime errors) where core pages referenced
non-existent MintyPHP\Service\Audit\AuditMetadataEnricher and SystemAuditService.
Add AuditMetadataEnricherInterface with NullAuditMetadataEnricher fallback so
deactivating the audit module no longer crashes core edit pages.

Move audit search resources from core Search*Provider files into the module
via a new AuditSearchResourceProvider implementing the existing
SearchResourceProvider contract. Add module-specific purge permissions
(audit.api.purge, audit.imports.purge) replacing core ABILITY_ADMIN_SETTINGS_UPDATE.

Also fixes: session key prefix convention, hardcoded English string, $_SERVER
superglobal fallback, and manifest schema drift (i18n_path, group in ui_slots).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-26 10:03:27 +01:00

118 lines
4.5 KiB
PHP

<?php
namespace MintyPHP\Tests\Architecture;
use PHPUnit\Framework\TestCase;
final class AuditModuleIsolationContractTest extends TestCase
{
public function testCoreServiceAuditDirectoryContainsOnlyInterfaces(): void
{
$dir = dirname(__DIR__, 2) . '/lib/Service/Audit';
self::assertDirectoryExists($dir);
$files = array_values(array_filter(
scandir($dir) ?: [],
static fn (string $f): bool => str_ends_with($f, '.php')
));
$allowed = [
'AuditMetadataEnricherInterface.php',
'AuditRecorderInterface.php',
'ImportAuditInterface.php',
'NullAuditMetadataEnricher.php',
'NullAuditRecorder.php',
'NullImportAudit.php',
'NullUserLifecycleAudit.php',
'UserLifecycleAuditInterface.php',
];
sort($files);
sort($allowed);
self::assertSame(
$allowed,
$files,
'lib/Service/Audit/ should contain only interfaces and null implementations, found: ' . implode(', ', $files)
);
}
public function testCoreRepositoryAuditDirectoryDoesNotExist(): void
{
$root = dirname(__DIR__, 2);
self::assertDirectoryDoesNotExist(
$root . '/lib/Repository/Audit',
'Audit repository classes should live in modules/audit/lib, not in Core lib/Repository/Audit'
);
}
public function testCoreDomainTaxonomyHasNoAuditEnums(): void
{
$dir = dirname(__DIR__, 2) . '/lib/Domain/Taxonomy';
if (!is_dir($dir)) {
self::addToAssertionCount(1);
return;
}
$entries = scandir($dir) ?: [];
$auditFiles = array_filter($entries, static fn (string $f): bool => str_contains($f, 'Audit') || str_contains($f, 'Lifecycle'));
self::assertSame(
[],
array_values($auditFiles),
'Core lib/Domain/Taxonomy/ still contains audit enum files: ' . implode(', ', $auditFiles)
);
}
public function testCoreAuditPagesRemoved(): void
{
$root = dirname(__DIR__, 2);
self::assertDirectoryDoesNotExist($root . '/pages/admin/api-audit');
self::assertDirectoryDoesNotExist($root . '/pages/admin/system-audit');
self::assertDirectoryDoesNotExist($root . '/pages/admin/import-audit');
self::assertDirectoryDoesNotExist($root . '/pages/admin/user-lifecycle-audit');
self::assertDirectoryDoesNotExist($root . '/pages/admin/frontend-telemetry');
}
public function testCoreJsHasNoAuditPageScripts(): void
{
$root = dirname(__DIR__, 2);
self::assertFileDoesNotExist($root . '/web/js/pages/admin-api-audit-index.js');
self::assertFileDoesNotExist($root . '/web/js/pages/admin-system-audit-index.js');
self::assertFileDoesNotExist($root . '/web/js/pages/admin-import-audit-index.js');
self::assertFileDoesNotExist($root . '/web/js/pages/admin-user-lifecycle-audit-index.js');
}
public function testCoreHttpHasNoConcreteAuditReporter(): void
{
$root = dirname(__DIR__, 2);
self::assertFileDoesNotExist(
$root . '/lib/Http/ApiSystemAuditReporter.php',
'ApiSystemAuditReporter should live in modules/audit/lib, not in Core lib/Http'
);
}
public function testCoreSidebarHasNoHardcodedAuditNavigation(): void
{
$file = dirname(__DIR__, 2) . '/templates/partials/app-main-aside.phtml';
$content = file_get_contents($file);
self::assertIsString($content);
self::assertStringNotContainsString('can_view_api_audit', $content);
self::assertStringNotContainsString('can_view_system_audit', $content);
self::assertStringNotContainsString('can_view_imports_audit', $content);
self::assertStringNotContainsString('can_view_user_lifecycle_audit', $content);
self::assertStringNotContainsString('admin/api-audit', $content);
self::assertStringNotContainsString('admin/system-audit', $content);
self::assertStringNotContainsString('admin/import-audit', $content);
self::assertStringNotContainsString('admin/user-lifecycle-audit', $content);
}
public function testCoreSchedulerHandlerRemoved(): void
{
$root = dirname(__DIR__, 2);
self::assertFileDoesNotExist(
$root . '/lib/Service/Scheduler/Handler/SystemAuditPurgeJobHandler.php',
'SystemAuditPurgeJobHandler should live in modules/audit, not in Core'
);
}
}