Rename the top-level lib/ directory to core/ so the project root immediately communicates which code is core platform and which lives in modules/. PHP namespaces (MintyPHP\*) are unchanged — only the Composer PSR-4 path mapping moves from lib/ to core/. Module-internal lib/ directories (modules/*/lib/) are untouched. Updated across the full stack: - composer.json PSR-4 mapping - bootstrap entry points (web/index.php, bin/*, tests/bootstrap.php) - tooling configs (phpstan.neon, phpunit.xml, php-cs-fixer) - 26 architecture contract tests - enforcement-policy, guard-catalog, quality-gates - all documentation (CLAUDE.md, README, 25 docs/, .agents/skills/) - bin/qa-extended.sh search paths - .claude/settings.local.json permission paths Workflow: .agents/runs/CORE-LIB-RENAME-001/ (Analyst → Planner → Executor → Code Review (4 findings fixed) → Security Review → Acceptance Test → Finalizer) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
41 lines
1.5 KiB
PHP
41 lines
1.5 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class SecurityLoggingRuntimeContractTest extends TestCase
|
|
{
|
|
use ProjectFileAssertionSupport;
|
|
|
|
public function testFrontendTelemetryIngestUsesOnlyRequestScopedErrorLogFallback(): void
|
|
{
|
|
$violations = array_merge(
|
|
$this->findPatternMatchesInPhpFiles('core', '/\berror_log\s*\(/'),
|
|
$this->findPatternMatchesInPhpFiles('pages', '/\berror_log\s*\(/'),
|
|
$this->findPatternMatchesInPhpFiles('modules', '/\berror_log\s*\(/')
|
|
);
|
|
sort($violations);
|
|
|
|
self::assertSame(
|
|
['modules/audit/pages/audit/frontend-telemetry/ingest().php'],
|
|
$violations,
|
|
"Unexpected error_log() usage outside the telemetry ingest fallback:\n" . implode("\n", $violations)
|
|
);
|
|
|
|
$content = $this->readProjectFile('modules/audit/pages/audit/frontend-telemetry/ingest().php');
|
|
self::assertStringContainsString(
|
|
"error_log('[frontend-telemetry] ingest record_failed request_id=' . RequestContext::id());",
|
|
$content
|
|
);
|
|
|
|
preg_match('/^.*\berror_log\s*\(.*$/m', $content, $matches);
|
|
$errorLogLine = $matches[0] ?? '';
|
|
|
|
self::assertNotSame('', $errorLogLine, 'Expected a dedicated telemetry error_log() fallback line.');
|
|
self::assertStringNotContainsString('$payload', $errorLogLine);
|
|
self::assertStringNotContainsString('$record', $errorLogLine);
|
|
self::assertStringNotContainsString('$events', $errorLogLine);
|
|
}
|
|
}
|