fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(settings/user-lifecycle): flat policy fields, danger stays in card

Browse Source 
Drops the wrapping details-card around the inactivity-policy fields so
they read like the email page (flat grid, no extra chrome). The
"Run lifecycle now" danger action keeps its details-card so the
destructive button stays visually separated from the form inputs.
The redundant info blockquote that paraphrased the field labels is gone.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-04-25 09:43:15 +02:00
parent 5b972b3633
commit 466fcac866
3 changed files with 18 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
i18n/default_de.json
View File

@@ -509,6 +509,7 @@
"Inactive tenants are excluded from user access and tenant-scoped data.": "Inaktive Mandanten werden vom Benutzerzugriff und mandantenspezifischen Daten ausgeschlossen.", "Inactive tenants are excluded from user access and tenant-scoped data.": "Inaktive Mandanten werden vom Benutzerzugriff und mandantenspezifischen Daten ausgeschlossen.",
"Inactive users": "Inaktive Benutzer", "Inactive users": "Inaktive Benutzer",
"Inactivity deactivation and deletion policy": "Richtlinie für Inaktivitäts-Deaktivierung und Löschung", "Inactivity deactivation and deletion policy": "Richtlinie für Inaktivitäts-Deaktivierung und Löschung",
"Inactivity policy": "Inaktivitätsrichtlinie",
"Incomplete": "Unvollständig", "Incomplete": "Unvollständig",
"Inherit global default": "Globalen Standard verwenden", "Inherit global default": "Globalen Standard verwenden",
"Internal Server Error": "Interner Serverfehler", "Internal Server Error": "Interner Serverfehler",

1
i18n/default_en.json
View File

@@ -509,6 +509,7 @@
"Inactive tenants are excluded from user access and tenant-scoped data.": "Inactive tenants are excluded from user access and tenant-scoped data.", "Inactive tenants are excluded from user access and tenant-scoped data.": "Inactive tenants are excluded from user access and tenant-scoped data.",
"Inactive users": "Inactive users", "Inactive users": "Inactive users",
"Inactivity deactivation and deletion policy": "Inactivity deactivation and deletion policy", "Inactivity deactivation and deletion policy": "Inactivity deactivation and deletion policy",
"Inactivity policy": "Inactivity policy",
"Incomplete": "Incomplete", "Incomplete": "Incomplete",
"Inherit global default": "Inherit global default", "Inherit global default": "Inherit global default",
"Internal Server Error": "Internal Server Error", "Internal Server Error": "Internal Server Error",

46
pages/admin/settings/user-lifecycle(default).phtml
View File

@@ -47,36 +47,22 @@ $readonlyAttr = $isReadOnly ? 'readonly' : '';
?> ?>
<form id="settings-user-lifecycle-form" method="post" data-details-storage="settings-user-lifecycle-details-v1" data-standard-detail-form="1"> <form id="settings-user-lifecycle-form" method="post" data-details-storage="settings-user-lifecycle-details-v1" data-standard-detail-form="1">
<details class="app-details-card" name="settings-user-lifecycle-policy" data-details-key="settings-user-lifecycle-policy" open> <div class="grid">
<summary> <label class="app-field">
<span class="app-details-card-summary-title"><?php e(t('User lifecycle policy')); ?></span> <span><?php e(t('Deactivate users after inactivity (days)')); ?></span>
<span class="app-details-card-summary-meta"> <input type="number" name="user_inactivity_deactivate_days"
<span class="badge" data-variant="neutral"><?php e((string) $userInactivityDeactivateDays); ?></span> value="<?php e((string) $userInactivityDeactivateDays); ?>" min="0" max="3650" step="1"
<span class="badge" data-variant="neutral"><?php e((string) $userInactivityDeleteDays); ?></span> <?php e($readonlyAttr); ?>>
</span> <small><?php e(t($userInactivityDeactivateDaysDesc)); ?> — <?php e(t('0 disables this rule')); ?></small>
</summary> </label>
<div class="app-details-card-container"> <label class="app-field">
<blockquote data-variant="info"> <span><?php e(t('Delete inactive users after (days)')); ?></span>
<small><?php e(t('User lifecycle defines when inactive users are deactivated or deleted.')); ?></small> <input type="number" name="user_inactivity_delete_days"
</blockquote> value="<?php e((string) $userInactivityDeleteDays); ?>" min="0" max="3650" step="1"
<div class="grid"> <?php e($readonlyAttr); ?>>
<label class="app-field"> <small><?php e(t($userInactivityDeleteDaysDesc)); ?> — <?php e(t('0 disables this rule')); ?></small>
<span><?php e(t('Deactivate users after inactivity (days)')); ?></span> </label>
<input type="number" name="user_inactivity_deactivate_days" </div>
value="<?php e((string) $userInactivityDeactivateDays); ?>" min="0" max="3650" step="1"
<?php e($readonlyAttr); ?>>
<small><?php e(t($userInactivityDeactivateDaysDesc)); ?> - <?php e(t('0 disables this rule')); ?></small>
</label>
<label class="app-field">
<span><?php e(t('Delete inactive users after (days)')); ?></span>
<input type="number" name="user_inactivity_delete_days"
value="<?php e((string) $userInactivityDeleteDays); ?>" min="0" max="3650" step="1"
<?php e($readonlyAttr); ?>>
<small><?php e(t($userInactivityDeleteDaysDesc)); ?> - <?php e(t('0 disables this rule')); ?></small>
</label>
</div>
</div>
</details>
<?php if ($canUpdateSettings): ?> <?php if ($canUpdateSettings): ?>
<details class="app-details-card" name="settings-user-lifecycle-run-now" data-details-key="settings-user-lifecycle-run-now"> <details class="app-details-card" name="settings-user-lifecycle-run-now" data-details-key="settings-user-lifecycle-run-now">