From 466fcac8662e246d0e77c57f1b8956221f8f27f5 Mon Sep 17 00:00:00 2001
From: fs <fs@breadcrumb-solutions.de>
Date: Sat, 25 Apr 2026 09:43:15 +0200
Subject: [PATCH] refactor(settings/user-lifecycle): flat policy fields, danger
 stays in card

Drops the wrapping details-card around the inactivity-policy fields so
they read like the email page (flat grid, no extra chrome). The
"Run lifecycle now" danger action keeps its details-card so the
destructive button stays visually separated from the form inputs.
The redundant info blockquote that paraphrased the field labels is gone.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 i18n/default_de.json                          |  1 +
 i18n/default_en.json                          |  1 +
 .../settings/user-lifecycle(default).phtml    | 46 +++++++------------
 3 files changed, 18 insertions(+), 30 deletions(-)

diff --git a/i18n/default_de.json b/i18n/default_de.json
index 651c3ac..2087f85 100644
--- a/i18n/default_de.json
+++ b/i18n/default_de.json
@@ -509,6 +509,7 @@
   "Inactive tenants are excluded from user access and tenant-scoped data.": "Inaktive Mandanten werden vom Benutzerzugriff und mandantenspezifischen Daten ausgeschlossen.",
   "Inactive users": "Inaktive Benutzer",
   "Inactivity deactivation and deletion policy": "Richtlinie für Inaktivitäts-Deaktivierung und Löschung",
+  "Inactivity policy": "Inaktivitätsrichtlinie",
   "Incomplete": "Unvollständig",
   "Inherit global default": "Globalen Standard verwenden",
   "Internal Server Error": "Interner Serverfehler",
diff --git a/i18n/default_en.json b/i18n/default_en.json
index 93f9b9d..362b65c 100644
--- a/i18n/default_en.json
+++ b/i18n/default_en.json
@@ -509,6 +509,7 @@
   "Inactive tenants are excluded from user access and tenant-scoped data.": "Inactive tenants are excluded from user access and tenant-scoped data.",
   "Inactive users": "Inactive users",
   "Inactivity deactivation and deletion policy": "Inactivity deactivation and deletion policy",
+  "Inactivity policy": "Inactivity policy",
   "Incomplete": "Incomplete",
   "Inherit global default": "Inherit global default",
   "Internal Server Error": "Internal Server Error",
diff --git a/pages/admin/settings/user-lifecycle(default).phtml b/pages/admin/settings/user-lifecycle(default).phtml
index 79ae05f..c3efde5 100644
--- a/pages/admin/settings/user-lifecycle(default).phtml
+++ b/pages/admin/settings/user-lifecycle(default).phtml
@@ -47,36 +47,22 @@ $readonlyAttr = $isReadOnly ? 'readonly' : '';
     ?>
 
     <form id="settings-user-lifecycle-form" method="post" data-details-storage="settings-user-lifecycle-details-v1" data-standard-detail-form="1">
-      <details class="app-details-card" name="settings-user-lifecycle-policy" data-details-key="settings-user-lifecycle-policy" open>
-        <summary>
-          <span class="app-details-card-summary-title"><?php e(t('User lifecycle policy')); ?></span>
-          <span class="app-details-card-summary-meta">
-            <span class="badge" data-variant="neutral"><?php e((string) $userInactivityDeactivateDays); ?></span>
-            <span class="badge" data-variant="neutral"><?php e((string) $userInactivityDeleteDays); ?></span>
-          </span>
-        </summary>
-        <div class="app-details-card-container">
-          <blockquote data-variant="info">
-            <small><?php e(t('User lifecycle defines when inactive users are deactivated or deleted.')); ?></small>
-          </blockquote>
-          <div class="grid">
-            <label class="app-field">
-              <span><?php e(t('Deactivate users after inactivity (days)')); ?></span>
-              <input type="number" name="user_inactivity_deactivate_days"
-                value="<?php e((string) $userInactivityDeactivateDays); ?>" min="0" max="3650" step="1"
-                <?php e($readonlyAttr); ?>>
-              <small><?php e(t($userInactivityDeactivateDaysDesc)); ?> - <?php e(t('0 disables this rule')); ?></small>
-            </label>
-            <label class="app-field">
-              <span><?php e(t('Delete inactive users after (days)')); ?></span>
-              <input type="number" name="user_inactivity_delete_days"
-                value="<?php e((string) $userInactivityDeleteDays); ?>" min="0" max="3650" step="1"
-                <?php e($readonlyAttr); ?>>
-              <small><?php e(t($userInactivityDeleteDaysDesc)); ?> - <?php e(t('0 disables this rule')); ?></small>
-            </label>
-          </div>
-        </div>
-      </details>
+      <div class="grid">
+        <label class="app-field">
+          <span><?php e(t('Deactivate users after inactivity (days)')); ?></span>
+          <input type="number" name="user_inactivity_deactivate_days"
+            value="<?php e((string) $userInactivityDeactivateDays); ?>" min="0" max="3650" step="1"
+            <?php e($readonlyAttr); ?>>
+          <small><?php e(t($userInactivityDeactivateDaysDesc)); ?> — <?php e(t('0 disables this rule')); ?></small>
+        </label>
+        <label class="app-field">
+          <span><?php e(t('Delete inactive users after (days)')); ?></span>
+          <input type="number" name="user_inactivity_delete_days"
+            value="<?php e((string) $userInactivityDeleteDays); ?>" min="0" max="3650" step="1"
+            <?php e($readonlyAttr); ?>>
+          <small><?php e(t($userInactivityDeleteDaysDesc)); ?> — <?php e(t('0 disables this rule')); ?></small>
+        </label>
+      </div>
 
       <?php if ($canUpdateSettings): ?>
         <details class="app-details-card" name="settings-user-lifecycle-run-now" data-details-key="settings-user-lifecycle-run-now">