forked from fa/breadcrumb-the-shire
Replace the single tenant avatar with a pair of theme-scoped brand logos.
Render only the theme-matching <img> server-side and swap src on theme
toggle via a JS hook — no reload, no double request, no CSS tricks.
Tenant logos
- TenantLogoService (ImageUploadTrait) with theme whitelist and per-theme
storage storage/tenants/{uuid}/logo/{light|dark}/, SIZES 128/256/512
- Public serving endpoint auth/tenant-logo-file so login can show the
logo pre-auth; matching authenticated admin preview endpoint
- appTenantLogoUrl(?size, ?theme) with 4-step fallback cascade; PDF +
mail always request 'light'
- Admin tenant edit: avatar block replaced by "Tenant logos" details
block inside the Master-data tab, two side-by-side slots via Pico
.grid with the core app-file-upload partial
- Policy rename ABILITY_ADMIN_TENANTS_AVATAR_VIEW -> LOGO_VIEW, action
routes logo / logo-delete / logo-file with theme body/query param
- API endpoint path kept (backward compat), internals on new service
- CLI tenant:logo-migrate-avatars moves legacy avatar/ -> logo/light/
idempotently (--dry-run, --yes, --cleanup)
- i18n "Tenant image" removed, 12 new keys synced across de/en
File upload component
- Full-width preview + filename/actions below (3D stack layout)
- Fixed 16:9 aspect ratio with 1rem inner padding for consistent
preview size across any logo aspect
- Transparency checker pattern as background so black logos stay
visible on dark mode and white logos on light mode
- form="" + deleteFormId support so the partial works with barrier
forms inside another form
Buttons
- width:100% dropped from button[type="submit"]; scoped back via
.login-main for the auth-flow primary CTA
- .outline base rule now tints background via color-mix of --app-color
so secondary/primary/danger outlines all gain a subtle surface
- .outline.secondary restyled Stripe-style in both themes: solid white
chip with soft shadow in light, solid elevated dark chip with white
text in dark; neutral border replaces role-colored border
- .app-action-success/.app-action-danger outlines get color-mix bg +
theme-aware outline-text tokens for stronger contrast
- Filled .primary/.app-action-success/.app-action-danger get raised
box-shadow (inset highlight + drop) — opt-in via class so chrome
buttons stay flat
- Dropped the legacy .secondary utility that was clobbering the
custom-property cascade with a hardcoded muted color
Theme swap
- Logo img carries data-src-light + data-src-dark; theme-toggle JS
swaps src when data-theme changes, keeping the topbar/login logo in
sync without a page reload
Quality gates: PHPUnit (2045), PHPStan L5, CS-Fixer, docs link/drift,
codex skills sync — all green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
116 lines
3.9 KiB
PHP
116 lines
3.9 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Service\Tenant;
|
|
|
|
use MintyPHP\Service\Tenant\TenantLogoService;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
/**
|
|
* Service behaviour test. Upload flows are covered via path-independent
|
|
* assertions (MIME + SVG guards + dir creation semantics) because
|
|
* move_uploaded_file() requires a real HTTP-uploaded file and cannot run
|
|
* under phpunit. Integration coverage for the move step lives in the
|
|
* manual smoketest documented in the execution report.
|
|
*/
|
|
class TenantLogoServiceTest extends TestCase
|
|
{
|
|
private TenantLogoService $service;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
$this->service = new TenantLogoService();
|
|
}
|
|
|
|
public function testIsValidThemeAcceptsWhitelistedThemes(): void
|
|
{
|
|
$this->assertTrue($this->service->isValidTheme('light'));
|
|
$this->assertTrue($this->service->isValidTheme('dark'));
|
|
}
|
|
|
|
public function testIsValidThemeRejectsUnknownThemes(): void
|
|
{
|
|
$this->assertFalse($this->service->isValidTheme(''));
|
|
$this->assertFalse($this->service->isValidTheme('dark-green'));
|
|
$this->assertFalse($this->service->isValidTheme('LIGHT'));
|
|
}
|
|
|
|
public function testIsValidUuidRejectsMalformedInput(): void
|
|
{
|
|
$this->assertFalse($this->service->isValidUuid('not-a-uuid'));
|
|
$this->assertFalse($this->service->isValidUuid(''));
|
|
}
|
|
|
|
public function testIsValidUuidAcceptsCanonicalUuid(): void
|
|
{
|
|
$this->assertTrue($this->service->isValidUuid('11111111-2222-3333-4444-555555555555'));
|
|
}
|
|
|
|
public function testFindLogoPathRejectsInvalidTheme(): void
|
|
{
|
|
$this->assertNull($this->service->findLogoPath('11111111-2222-3333-4444-555555555555', 'neon'));
|
|
}
|
|
|
|
public function testFindLogoPathRejectsInvalidUuid(): void
|
|
{
|
|
$this->assertNull($this->service->findLogoPath('bogus', 'light'));
|
|
}
|
|
|
|
public function testHasLogoReturnsFalseForMissingDirectory(): void
|
|
{
|
|
$this->assertFalse($this->service->hasLogo('11111111-2222-3333-4444-555555555555', 'light'));
|
|
}
|
|
|
|
public function testTenantLogoDirIncludesThemeSegment(): void
|
|
{
|
|
$uuid = '11111111-2222-3333-4444-555555555555';
|
|
$this->assertStringEndsWith('/tenants/' . $uuid . '/logo/light', $this->service->tenantLogoDir($uuid, 'light'));
|
|
$this->assertStringEndsWith('/tenants/' . $uuid . '/logo/dark', $this->service->tenantLogoDir($uuid, 'dark'));
|
|
}
|
|
|
|
public function testSaveUploadRejectsInvalidUuid(): void
|
|
{
|
|
$result = $this->service->saveUpload('not-uuid', 'light', [
|
|
'tmp_name' => '/tmp/whatever',
|
|
'error' => UPLOAD_ERR_OK,
|
|
'size' => 100,
|
|
]);
|
|
$this->assertFalse($result['ok']);
|
|
}
|
|
|
|
public function testSaveUploadRejectsInvalidTheme(): void
|
|
{
|
|
$result = $this->service->saveUpload('11111111-2222-3333-4444-555555555555', 'neon', [
|
|
'tmp_name' => '/tmp/whatever',
|
|
'error' => UPLOAD_ERR_OK,
|
|
'size' => 100,
|
|
]);
|
|
$this->assertFalse($result['ok']);
|
|
}
|
|
|
|
public function testSaveUploadRejectsOversizedFile(): void
|
|
{
|
|
$result = $this->service->saveUpload('11111111-2222-3333-4444-555555555555', 'light', [
|
|
'tmp_name' => '/tmp/whatever',
|
|
'error' => UPLOAD_ERR_OK,
|
|
'size' => 10 * 1024 * 1024,
|
|
]);
|
|
$this->assertFalse($result['ok']);
|
|
}
|
|
|
|
public function testSaveUploadRejectsMissingFile(): void
|
|
{
|
|
$result = $this->service->saveUpload('11111111-2222-3333-4444-555555555555', 'light', []);
|
|
$this->assertFalse($result['ok']);
|
|
}
|
|
|
|
public function testDeleteRejectsInvalidUuid(): void
|
|
{
|
|
$this->assertFalse($this->service->delete('bogus', 'light'));
|
|
}
|
|
|
|
public function testDeleteRejectsInvalidTheme(): void
|
|
{
|
|
$this->assertFalse($this->service->delete('11111111-2222-3333-4444-555555555555', 'neon'));
|
|
}
|
|
}
|