forked from fa/breadcrumb-the-shire
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline from 486 to 382 entries (only unused-public false positives remain). Categories fixed: - Remove 39 redundant type checks (is_string, is_array, is_object, method_exists) - Remove 12 no-op array_values() on already-sequential lists - Simplify 13 null-coalesce on guaranteed offsets - Remove 8 always-true instanceof checks - Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount) - Simplify 6 unnecessary nullsafe operators (?-> → ->) - Fix 6 always-true !== '' comparisons - Fix remaining: unset.offset, return.unusedType, staticMethod narrowing 53 files changed across core/, modules/, pages/, and tests/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
242 lines
8.3 KiB
PHP
242 lines
8.3 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Support;
|
|
|
|
use MintyPHP\App\Module\Contracts\SearchResourceProvider;
|
|
use MintyPHP\App\Module\ModuleRegistry;
|
|
use MintyPHP\Support\Search\SearchItemMapperProvider;
|
|
use MintyPHP\Support\Search\SearchQueryNormalizer;
|
|
use MintyPHP\Support\Search\SearchSpecialResourceProvider;
|
|
use MintyPHP\Support\Search\SearchSqlResourceProvider;
|
|
use MintyPHP\Support\Search\SearchUiMetaProvider;
|
|
|
|
class SearchConfig
|
|
{
|
|
/** @var list<SearchResourceProvider> resolved module providers (cached per request) */
|
|
private static ?array $moduleProviders = null;
|
|
|
|
/** @var array<string, SearchResourceProvider> key→provider lookup */
|
|
private static array $moduleProviderByKey = [];
|
|
|
|
/** @var (callable(): ModuleRegistry)|null */
|
|
private static $moduleRegistryResolver = null;
|
|
/** @var (callable(string): ?object)|null */
|
|
private static $moduleClassResolver = null;
|
|
|
|
public static function configure(callable $moduleRegistryResolver, ?callable $moduleClassResolver = null): void
|
|
{
|
|
self::$moduleRegistryResolver = $moduleRegistryResolver;
|
|
self::$moduleClassResolver = $moduleClassResolver !== null
|
|
? \Closure::fromCallable($moduleClassResolver)
|
|
: null;
|
|
self::resetModuleProviders();
|
|
}
|
|
|
|
public static function tenantScopeFilters(): array
|
|
{
|
|
$filters = SearchSqlResourceProvider::tenantScopeFilters();
|
|
|
|
// Module providers may contribute tenant scope filters via their resource definitions
|
|
foreach (self::resolveModuleProviders() as $provider) {
|
|
foreach ($provider->resources() as $key => $resource) {
|
|
if (isset($resource['tenant_filter']) && $resource['tenant_filter'] !== '') {
|
|
$filters[$key] = $resource['tenant_filter'];
|
|
}
|
|
}
|
|
}
|
|
|
|
return $filters;
|
|
}
|
|
|
|
public static function resources(string $query, string $locale): array
|
|
{
|
|
return SearchSqlResourceProvider::resources($query, $locale);
|
|
}
|
|
|
|
/**
|
|
* Return module-contributed search resource definitions.
|
|
* These are separate from core SQL resources and processed by SearchDataService.
|
|
*
|
|
* @return array<string, array{label: string, permission: string, count_sql: string, preview_sql: string, result_sql: string, tenant_filter?: string}>
|
|
*/
|
|
public static function moduleResources(): array
|
|
{
|
|
$resources = [];
|
|
foreach (self::resolveModuleProviders() as $provider) {
|
|
foreach ($provider->resources() as $key => $resource) {
|
|
$resources[$key] = $resource;
|
|
}
|
|
}
|
|
return $resources;
|
|
}
|
|
|
|
public static function iconForKey(string $key): string
|
|
{
|
|
// Check module provider key→icon mapping
|
|
$moduleProvider = self::$moduleProviderByKey[$key] ?? null;
|
|
if ($moduleProvider !== null) {
|
|
$mapped = $moduleProvider->mapResultItem($key, []);
|
|
if ($mapped !== null && isset($mapped['icon']) && $mapped['icon'] !== '') {
|
|
return $mapped['icon'];
|
|
}
|
|
}
|
|
|
|
return SearchUiMetaProvider::iconForKey($key);
|
|
}
|
|
|
|
public static function listUrl(string $key, string $query): string
|
|
{
|
|
// Ensure module providers are resolved before lookup
|
|
self::resolveModuleProviders();
|
|
$provider = self::$moduleProviderByKey[$key] ?? null;
|
|
if ($provider !== null) {
|
|
$url = $provider->listUrl($key, urlencode($query));
|
|
if ($url !== '') {
|
|
return $url;
|
|
}
|
|
}
|
|
|
|
return SearchUiMetaProvider::listUrl($key, $query);
|
|
}
|
|
|
|
public static function mapPreviewItem(string $key, array $data, string $query): ?array
|
|
{
|
|
self::resolveModuleProviders();
|
|
$provider = self::$moduleProviderByKey[$key] ?? null;
|
|
if ($provider !== null) {
|
|
$mapped = $provider->mapResultItem($key, $data);
|
|
if ($mapped !== null) {
|
|
$item = ['label' => $mapped['title'], 'url' => $mapped['url']];
|
|
if (isset($mapped['subtitle']) && $mapped['subtitle'] !== '') {
|
|
$item['subtitle'] = $mapped['subtitle'];
|
|
}
|
|
if (isset($mapped['icon']) && $mapped['icon'] !== '') {
|
|
$item['icon'] = $mapped['icon'];
|
|
}
|
|
return $item;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
return SearchItemMapperProvider::mapPreviewItem($key, $data, $query);
|
|
}
|
|
|
|
public static function mapResultItem(string $key, string $label, array $data): ?array
|
|
{
|
|
self::resolveModuleProviders();
|
|
$provider = self::$moduleProviderByKey[$key] ?? null;
|
|
if ($provider !== null) {
|
|
$mapped = $provider->mapResultItem($key, $data);
|
|
if ($mapped !== null) {
|
|
return [
|
|
'type' => $label,
|
|
'title' => $mapped['title'],
|
|
'description' => $mapped['subtitle'] ?? '',
|
|
'url' => $mapped['url'],
|
|
'image' => '',
|
|
'icon' => $mapped['icon'] ?? self::iconForKey($key),
|
|
];
|
|
}
|
|
return null;
|
|
}
|
|
|
|
return SearchItemMapperProvider::mapResultItem($key, $label, $data);
|
|
}
|
|
|
|
/**
|
|
* Resolve and cache module search providers for the current request.
|
|
*
|
|
* @return list<SearchResourceProvider>
|
|
*/
|
|
private static function resolveModuleProviders(): array
|
|
{
|
|
if (self::$moduleProviders !== null) {
|
|
return self::$moduleProviders;
|
|
}
|
|
|
|
self::$moduleProviders = [];
|
|
self::$moduleProviderByKey = [];
|
|
|
|
if (!is_callable(self::$moduleRegistryResolver)) {
|
|
return self::$moduleProviders;
|
|
}
|
|
|
|
try {
|
|
$registry = (self::$moduleRegistryResolver)();
|
|
foreach ($registry->getSearchResources() as $providerClass) {
|
|
$provider = self::resolveModuleProvider($providerClass);
|
|
if ($provider instanceof SearchResourceProvider) {
|
|
self::$moduleProviders[] = $provider;
|
|
foreach ($provider->resources() as $key => $resource) {
|
|
self::$moduleProviderByKey[$key] = $provider;
|
|
}
|
|
}
|
|
}
|
|
} catch (\Throwable) {
|
|
// fail-open: module registry may not be available
|
|
}
|
|
|
|
return self::$moduleProviders;
|
|
}
|
|
|
|
/**
|
|
* Reset cached module providers (for testing).
|
|
*/
|
|
public static function resetModuleProviders(): void
|
|
{
|
|
self::$moduleProviders = null;
|
|
self::$moduleProviderByKey = [];
|
|
}
|
|
|
|
private static function resolveModuleProvider(string $providerClass): ?SearchResourceProvider
|
|
{
|
|
try {
|
|
if (is_callable(self::$moduleClassResolver)) {
|
|
$resolved = (self::$moduleClassResolver)($providerClass);
|
|
return $resolved instanceof SearchResourceProvider ? $resolved : null;
|
|
}
|
|
|
|
if (!class_exists($providerClass)) {
|
|
return null;
|
|
}
|
|
|
|
$reflection = new \ReflectionClass($providerClass);
|
|
$constructor = $reflection->getConstructor();
|
|
if ($constructor !== null && $constructor->getNumberOfRequiredParameters() > 0) {
|
|
return null;
|
|
}
|
|
|
|
$instance = $reflection->newInstance();
|
|
return $instance instanceof SearchResourceProvider ? $instance : null;
|
|
} catch (\Throwable) {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
public static function hotkeyPreviewResource(string $query): ?array
|
|
{
|
|
return SearchSpecialResourceProvider::hotkeyPreviewResource($query);
|
|
}
|
|
|
|
public static function hotkeyResultItems(string $query): array
|
|
{
|
|
return SearchSpecialResourceProvider::hotkeyResultItems($query);
|
|
}
|
|
|
|
public static function docsPreviewResource(string $query): ?array
|
|
{
|
|
return SearchSpecialResourceProvider::docsPreviewResource($query);
|
|
}
|
|
|
|
public static function docsResultItems(string $query): array
|
|
{
|
|
return SearchSpecialResourceProvider::docsResultItems($query);
|
|
}
|
|
|
|
public static function normalizeScoreQuery(string $query): string
|
|
{
|
|
return SearchQueryNormalizer::normalizeScoreQuery($query);
|
|
}
|
|
|
|
}
|