forked from fa/breadcrumb-the-shire
fs
0c351f6aff
Move the entire audit subsystem (system audit, API audit, import audit, user lifecycle audit, frontend telemetry) from core into modules/audit/. Core decoupling via interface-based injection: - AuditRecorderInterface replaces SystemAuditService in 10+ core services - UserLifecycleAuditInterface / ImportAuditInterface for specialized flows - NullAuditRecorder fallback when audit module is disabled - ApiBootstrap/ApiResponse use null-safe callable resolvers Module structure (modules/audit/): - Manifest with routes, permissions, scheduler jobs, authorization policy - 9 services, 8 repositories, 6 domain enums, 4 job handlers - 33 page files, 4 JS files, 8 test files, migration scripts, i18n Core cleanup: - OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService surgically cleaned of audit-specific constants - Sidebar template cleared of hardcoded audit navigation - AuditModuleIsolationContractTest ensures no future core→module coupling All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5 clean, architecture contracts verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
61 lines
2.6 KiB
PHP
61 lines
2.6 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
use PHPUnit\Framework\Attributes\DataProvider;
|
|
use PHPUnit\Framework\TestCase;
|
|
use ReflectionClass;
|
|
use ReflectionMethod;
|
|
|
|
class ContainerFactoryContractTest extends TestCase
|
|
{
|
|
/**
|
|
* @return array<int, array{0: class-string}>
|
|
*/
|
|
public static function factoryClassProvider(): array
|
|
{
|
|
return [
|
|
[\MintyPHP\Service\Access\AccessServicesFactory::class],
|
|
[\MintyPHP\Module\AddressBook\Service\AddressBookServicesFactory::class],
|
|
[\MintyPHP\Module\Audit\Service\AuditServicesFactory::class],
|
|
[\MintyPHP\Service\Auth\AuthServicesFactory::class],
|
|
[\MintyPHP\Service\Branding\BrandingServicesFactory::class],
|
|
[\MintyPHP\Service\Directory\DirectoryServicesFactory::class],
|
|
[\MintyPHP\Service\Import\ImportServicesFactory::class],
|
|
[\MintyPHP\Service\Mail\MailServicesFactory::class],
|
|
[\MintyPHP\Service\Scheduler\SchedulerServicesFactory::class],
|
|
[\MintyPHP\Service\Security\SecurityServicesFactory::class],
|
|
[\MintyPHP\Service\Settings\SettingServicesFactory::class],
|
|
[\MintyPHP\Service\Tenant\TenantServicesFactory::class],
|
|
[\MintyPHP\Service\User\UserServicesFactory::class],
|
|
];
|
|
}
|
|
|
|
#[DataProvider('factoryClassProvider')]
|
|
public function testContainerFactoriesCachePublicNoArgCreateMethods(string $factoryClass): void
|
|
{
|
|
$factory = app($factoryClass);
|
|
$this->assertInstanceOf($factoryClass, $factory);
|
|
|
|
$reflection = new ReflectionClass($factoryClass);
|
|
$methods = array_filter(
|
|
$reflection->getMethods(ReflectionMethod::IS_PUBLIC),
|
|
static fn (ReflectionMethod $method): bool =>
|
|
!$method->isStatic()
|
|
&& str_starts_with($method->getName(), 'create')
|
|
&& $method->getNumberOfRequiredParameters() === 0
|
|
);
|
|
usort($methods, static fn (ReflectionMethod $a, ReflectionMethod $b): int => strcmp($a->getName(), $b->getName()));
|
|
|
|
foreach ($methods as $method) {
|
|
$methodName = $method->getName();
|
|
$first = $factory->{$methodName}();
|
|
$second = $factory->{$methodName}();
|
|
|
|
$this->assertIsObject($first, sprintf('%s::%s() must return an object', $factoryClass, $methodName));
|
|
$this->assertInstanceOf($first::class, $second, sprintf('%s::%s() must be type-stable', $factoryClass, $methodName));
|
|
$this->assertSame($first, $second, sprintf('%s::%s() must return the cached instance', $factoryClass, $methodName));
|
|
}
|
|
}
|
|
}
|