3f0db68b27
refactor: fix all 105 PHPStan 2 strict type findings across core and modules
...
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline
from 486 to 382 entries (only unused-public false positives remain).
Categories fixed:
- Remove 39 redundant type checks (is_string, is_array, is_object, method_exists)
- Remove 12 no-op array_values() on already-sequential lists
- Simplify 13 null-coalesce on guaranteed offsets
- Remove 8 always-true instanceof checks
- Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount)
- Simplify 6 unnecessary nullsafe operators (?-> → ->)
- Fix 6 always-true !== '' comparisons
- Fix remaining: unset.offset, return.unusedType, staticMethod narrowing
53 files changed across core/, modules/, pages/, and tests/.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-14 12:54:20 +02:00
143d887a5c
fix: patch remaining lib/ references missed in core/ rename
...
CliAppBootstrap and ModuleCliRuntime still required from the old
lib/ path, which would break all CLI commands. Also fixes stale
lib/ references in docs, test assertion messages, and a PHPDoc
comment.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-04-14 07:54:02 +02:00
