forked from fa/breadcrumb-the-shire
Harden module runtime: audited listener failures and DI-first resolver
This commit is contained in:
@@ -4,6 +4,8 @@ namespace MintyPHP\App\Module;
|
||||
|
||||
use MintyPHP\App\AppContainer;
|
||||
use MintyPHP\App\Module\Contracts\EventListener;
|
||||
use MintyPHP\Http\RequestContext;
|
||||
use MintyPHP\Service\Audit\SystemAuditService;
|
||||
|
||||
/**
|
||||
* Fire-and-forget event dispatcher for module lifecycle events.
|
||||
@@ -19,7 +21,8 @@ final class ModuleEventDispatcher
|
||||
*/
|
||||
public function __construct(
|
||||
private readonly array $listenerMap,
|
||||
private readonly AppContainer $container
|
||||
private readonly AppContainer $container,
|
||||
private readonly ?SystemAuditService $systemAuditService = null
|
||||
) {
|
||||
}
|
||||
|
||||
@@ -31,19 +34,42 @@ final class ModuleEventDispatcher
|
||||
$listeners = $this->listenerMap[$event] ?? [];
|
||||
|
||||
foreach ($listeners as $descriptor) {
|
||||
$class = '';
|
||||
$method = '';
|
||||
try {
|
||||
$class = $descriptor['class'];
|
||||
$method = $descriptor['method'];
|
||||
|
||||
$listener = $this->container->get($class);
|
||||
$listener = ModuleClassResolver::resolve($this->container, $class);
|
||||
if (!$listener instanceof EventListener) {
|
||||
$listener = new $class();
|
||||
continue;
|
||||
}
|
||||
|
||||
$listener->{$method}($event, $payload);
|
||||
} catch (\Throwable) {
|
||||
// Swallow — one failing listener must not break the chain.
|
||||
} catch (\Throwable $exception) {
|
||||
$this->recordListenerFailure($event, $class, $method, $exception);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private function recordListenerFailure(
|
||||
string $event,
|
||||
string $listenerClass,
|
||||
string $listenerMethod,
|
||||
\Throwable $exception
|
||||
): void {
|
||||
if ($this->systemAuditService === null) {
|
||||
return;
|
||||
}
|
||||
|
||||
$this->systemAuditService->record('module.listener.failed', 'failed', [
|
||||
'metadata' => [
|
||||
'module_event' => $event,
|
||||
'listener_class' => $listenerClass,
|
||||
'listener_method' => $listenerMethod,
|
||||
'exception_class' => $exception::class,
|
||||
'request_id' => RequestContext::id(),
|
||||
],
|
||||
]);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user