2026-03-19 19:08:28 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
|
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
|
|
|
|
|
|
final class SecurityLoggingRuntimeContractTest extends TestCase
|
|
|
|
|
{
|
|
|
|
|
use ProjectFileAssertionSupport;
|
|
|
|
|
|
|
|
|
|
public function testFrontendTelemetryIngestUsesOnlyRequestScopedErrorLogFallback(): void
|
|
|
|
|
{
|
|
|
|
|
$violations = array_merge(
|
2026-04-13 23:20:05 +02:00
|
|
|
$this->findPatternMatchesInPhpFiles('core', '/\berror_log\s*\(/'),
|
refactor(audit): extract audit domain into self-contained module
Move the entire audit subsystem (system audit, API audit, import audit,
user lifecycle audit, frontend telemetry) from core into modules/audit/.
Core decoupling via interface-based injection:
- AuditRecorderInterface replaces SystemAuditService in 10+ core services
- UserLifecycleAuditInterface / ImportAuditInterface for specialized flows
- NullAuditRecorder fallback when audit module is disabled
- ApiBootstrap/ApiResponse use null-safe callable resolvers
Module structure (modules/audit/):
- Manifest with routes, permissions, scheduler jobs, authorization policy
- 9 services, 8 repositories, 6 domain enums, 4 job handlers
- 33 page files, 4 JS files, 8 test files, migration scripts, i18n
Core cleanup:
- OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService
surgically cleaned of audit-specific constants
- Sidebar template cleared of hardcoded audit navigation
- AuditModuleIsolationContractTest ensures no future core→module coupling
All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5
clean, architecture contracts verified.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-25 21:12:49 +01:00
|
|
|
$this->findPatternMatchesInPhpFiles('pages', '/\berror_log\s*\(/'),
|
|
|
|
|
$this->findPatternMatchesInPhpFiles('modules', '/\berror_log\s*\(/')
|
2026-03-19 19:08:28 +01:00
|
|
|
);
|
|
|
|
|
sort($violations);
|
|
|
|
|
|
|
|
|
|
self::assertSame(
|
2026-03-26 08:13:37 +01:00
|
|
|
['modules/audit/pages/audit/frontend-telemetry/ingest().php'],
|
2026-03-19 19:08:28 +01:00
|
|
|
$violations,
|
|
|
|
|
"Unexpected error_log() usage outside the telemetry ingest fallback:\n" . implode("\n", $violations)
|
|
|
|
|
);
|
|
|
|
|
|
2026-03-26 08:13:37 +01:00
|
|
|
$content = $this->readProjectFile('modules/audit/pages/audit/frontend-telemetry/ingest().php');
|
2026-03-19 19:08:28 +01:00
|
|
|
self::assertStringContainsString(
|
|
|
|
|
"error_log('[frontend-telemetry] ingest record_failed request_id=' . RequestContext::id());",
|
|
|
|
|
$content
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
preg_match('/^.*\berror_log\s*\(.*$/m', $content, $matches);
|
|
|
|
|
$errorLogLine = $matches[0] ?? '';
|
|
|
|
|
|
|
|
|
|
self::assertNotSame('', $errorLogLine, 'Expected a dedicated telemetry error_log() fallback line.');
|
|
|
|
|
self::assertStringNotContainsString('$payload', $errorLogLine);
|
|
|
|
|
self::assertStringNotContainsString('$record', $errorLogLine);
|
|
|
|
|
self::assertStringNotContainsString('$events', $errorLogLine);
|
|
|
|
|
}
|
|
|
|
|
}
|