1
0
Files
breadcrumb-the-shire/core/Service/User/UserSettingsGateway.php

74 lines
2.0 KiB
PHP
Raw Normal View History

2026-02-23 12:58:19 +01:00
<?php
namespace MintyPHP\Service\User;
2026-03-06 00:44:52 +01:00
use MintyPHP\Service\Settings\SettingsAppGateway;
use MintyPHP\Service\Settings\SettingsDefaultsGateway;
use MintyPHP\Service\Settings\SettingsUserLifecycleGateway;
2026-02-23 12:58:19 +01:00
class UserSettingsGateway
{
2026-03-06 00:44:52 +01:00
public function __construct(
private readonly SettingsDefaultsGateway $settingsDefaultsGateway,
private readonly SettingsAppGateway $settingsAppGateway,
private readonly SettingsUserLifecycleGateway $settingsUserLifecycleGateway
) {
2026-02-23 12:58:19 +01:00
}
public function getDefaultTenantId(): ?int
{
2026-03-06 00:44:52 +01:00
return $this->settingsDefaultsGateway->getDefaultTenantId();
2026-02-23 12:58:19 +01:00
}
public function getDefaultRoleId(): ?int
{
2026-03-06 00:44:52 +01:00
return $this->settingsDefaultsGateway->getDefaultRoleId();
2026-02-23 12:58:19 +01:00
}
public function getDefaultDepartmentId(): ?int
{
2026-03-06 00:44:52 +01:00
return $this->settingsDefaultsGateway->getDefaultDepartmentId();
2026-02-23 12:58:19 +01:00
}
/**
* @return array<string, string>
*/
public function appThemes(): array
{
return $this->settingsAppGateway->listThemes();
}
public function defaultTheme(): string
{
return $this->settingsAppGateway->resolveDefaultTheme();
}
public function normalizeTheme(?string $theme): string
{
return $this->settingsAppGateway->normalizeTheme($theme);
}
2026-02-23 12:58:19 +01:00
public function getUserInactivityDeactivateDays(): int
{
2026-03-06 00:44:52 +01:00
return $this->settingsUserLifecycleGateway->getUserInactivityDeactivateDays();
2026-02-23 12:58:19 +01:00
}
public function getUserInactivityDeleteDays(): int
{
2026-03-06 00:44:52 +01:00
return $this->settingsUserLifecycleGateway->getUserInactivityDeleteDays();
2026-02-23 12:58:19 +01:00
}
fix(user-lifecycle): track last-run state in core, not in audit log The "Last run" KPI tile stayed empty after a manual policy run, even though the run completed successfully. Two distinct bugs were involved: 1. The dashboard read latestSystemRun() from the audit log filtered by trigger_type='system'. UserLifecycleService::run() never sets that value — it uses 'manual' for actor-triggered runs and 'cron' for scheduled ones. The query never matched anything. 2. Even with the right trigger_type, the audit log only writes per-user entries (logDeactivate / logDelete / logDeleteFailure). A run that processes zero users — including most cron ticks on a healthy tenant — leaves no trace, so the tile would still show "—" after a correct execution. Both bugs share one root cause: run-trigger state was being inferred from audit-log details, but those are two semantically different things. Audit log answers "what did the run do?". A "last run" tile answers "did the run happen?". This commit moves run-trigger state to the core settings table and keeps the audit log strictly for per-user events: * Two new keys in core/Service/Settings/SettingKeys — USER_LIFECYCLE_LAST_RUN_AT_KEY and USER_LIFECYCLE_LAST_RUN_STATUS_KEY. * SettingsUserLifecycleGateway gains recordLastRun() and getLastRun(). UserSettingsGateway exposes them as recordLifecycleLastRun() / getLifecycleLastRun() so UserLifecycleService can call through its existing dependency without growing its constructor. * UserLifecycleService::run() writes both keys in finally — every time the lock was acquired, regardless of whether any user was processed and regardless of whether the run finished cleanly. Status reflects $result['ok'] ('success' / 'failed'). * UserLifecyclePolicyDashboardService gains a lastRun() reader. Action page now sources the KPI tile from this core service instead of the audit interface — so the tile works even when the audit module is disabled. * The audit-side lastRun() / latestSystemRun() / their tests are removed (YAGNI). Phase 4 (activity feed) can rebuild from the audit filter grid without a special method. Behaviorally: a no-op run now records "Last run: just now · ✓ Success" in the cockpit, exactly as expected. All six quality gates green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-26 21:07:57 +02:00
public function recordLifecycleLastRun(string $createdAtUtc, string $status): bool
{
return $this->settingsUserLifecycleGateway->recordLastRun($createdAtUtc, $status);
}
/**
* @return array{created_at: string, status: string}|null
*/
public function getLifecycleLastRun(): ?array
{
return $this->settingsUserLifecycleGateway->getLastRun();
}
2026-02-23 12:58:19 +01:00
}