Remove the extensible theme catalog (config/themes.php + ThemeConfigGateway) in favor of a two-entry const on SettingsAppGateway. appThemes() now returns the list directly — no container lookup, no file include. Drop the dark-green theme assets, narrow [data-theme^="dark"] selectors to [data-theme="dark"], and tighten isDarkTheme() to an exact match. Ship an idempotent migration that corrects any leftover 'dark-green' rows on users and tenants to safe defaults (light / NULL). Tenant scoping (default_theme, allow_user_theme) and per-user override stay intact; only the catalog extensibility and the third theme are removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
129 lines
5.0 KiB
PHP
129 lines
5.0 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Service\Settings;
|
|
|
|
use MintyPHP\Repository\Settings\SettingRepositoryInterface;
|
|
use MintyPHP\Service\Settings\SettingsAppGateway;
|
|
use MintyPHP\Service\Settings\SettingsFrontendTelemetryGateway;
|
|
use MintyPHP\Service\Settings\SettingsMetadataGateway;
|
|
use MintyPHP\Service\Settings\SettingsSmtpGateway;
|
|
use MintyPHP\Service\Settings\SettingsSystemAuditGateway;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
final class SettingsGatewayNormalizationTest extends TestCase
|
|
{
|
|
public function testAppLocaleStoresNullForEmptyValue(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->expects($this->once())
|
|
->method('set')
|
|
->with('app_locale', null, 'setting.app_locale')
|
|
->willReturn(true);
|
|
|
|
$gateway = $this->newAppGateway($settings);
|
|
self::assertTrue($gateway->setAppLocale(' '));
|
|
}
|
|
|
|
public function testAppRegistrationDefaultIsTrueWhenUnset(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->method('getValue')->willReturnMap([
|
|
['app_registration', null],
|
|
]);
|
|
|
|
$gateway = $this->newAppGateway($settings);
|
|
self::assertTrue($gateway->isRegistrationEnabled());
|
|
}
|
|
|
|
public function testSystemAuditUsesFallbacksAndRejectsOutOfRangeRetention(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->method('getValue')->willReturnCallback(static function (string $key): ?string {
|
|
return $key === 'system_audit_retention_days' ? '5' : null;
|
|
});
|
|
$settings->expects($this->never())->method('set');
|
|
|
|
$gateway = new SettingsSystemAuditGateway(new SettingsMetadataGateway($settings));
|
|
self::assertTrue($gateway->isSystemAuditEnabled());
|
|
self::assertSame(365, $gateway->getSystemAuditRetentionDays());
|
|
self::assertFalse($gateway->setSystemAuditRetentionDays(10));
|
|
}
|
|
|
|
public function testFrontendTelemetryUsesDefaultsWhenSettingsMissing(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->method('getValue')->willReturn(null);
|
|
|
|
$gateway = new SettingsFrontendTelemetryGateway(new SettingsMetadataGateway($settings));
|
|
self::assertFalse($gateway->isFrontendTelemetryEnabled());
|
|
self::assertSame(0.2, $gateway->getFrontendTelemetrySampleRate());
|
|
self::assertSame(['warn_once', 'ajax_error'], $gateway->getFrontendTelemetryAllowedEvents());
|
|
}
|
|
|
|
public function testFrontendTelemetryRejectsOutOfRangeSampleRate(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->expects($this->never())->method('set');
|
|
|
|
$gateway = new SettingsFrontendTelemetryGateway(new SettingsMetadataGateway($settings));
|
|
self::assertFalse($gateway->setFrontendTelemetrySampleRate(1.5));
|
|
}
|
|
|
|
public function testFrontendTelemetryNormalizesAllowedEvents(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->expects($this->once())
|
|
->method('set')
|
|
->with(
|
|
'frontend_telemetry_allowed_events',
|
|
'ajax_error,warn_once',
|
|
'setting.frontend_telemetry_allowed_events'
|
|
)
|
|
->willReturn(true);
|
|
|
|
$gateway = new SettingsFrontendTelemetryGateway(new SettingsMetadataGateway($settings));
|
|
self::assertTrue($gateway->setFrontendTelemetryAllowedEvents(['frontend.warn_once', 'ajax_error', 'invalid']));
|
|
}
|
|
|
|
public function testSmtpSecureReturnsNullForNone(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->method('getValue')->willReturnCallback(static function (string $key): ?string {
|
|
if ($key === 'smtp_secure') {
|
|
return 'none';
|
|
}
|
|
|
|
return null;
|
|
});
|
|
|
|
$gateway = new SettingsSmtpGateway(new SettingsMetadataGateway($settings));
|
|
self::assertNull($gateway->getSmtpSecure());
|
|
}
|
|
|
|
public function testSmtpSecureRejectsInvalidValue(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->expects($this->never())->method('set');
|
|
|
|
$gateway = new SettingsSmtpGateway(new SettingsMetadataGateway($settings));
|
|
self::assertFalse($gateway->setSmtpSecure('starttls'));
|
|
}
|
|
|
|
public function testSmtpHostPersistsNullForEmptyString(): void
|
|
{
|
|
$settings = $this->createMock(SettingRepositoryInterface::class);
|
|
$settings->expects($this->once())
|
|
->method('set')
|
|
->with('smtp_host', null, 'setting.smtp_host')
|
|
->willReturn(true);
|
|
|
|
$gateway = new SettingsSmtpGateway(new SettingsMetadataGateway($settings));
|
|
self::assertTrue($gateway->setSmtpHost(' '));
|
|
}
|
|
|
|
private function newAppGateway(SettingRepositoryInterface $settingRepository): SettingsAppGateway
|
|
{
|
|
return new SettingsAppGateway(new SettingsMetadataGateway($settingRepository));
|
|
}
|
|
}
|