fs
3f0db68b27
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline from 486 to 382 entries (only unused-public false positives remain). Categories fixed: - Remove 39 redundant type checks (is_string, is_array, is_object, method_exists) - Remove 12 no-op array_values() on already-sequential lists - Simplify 13 null-coalesce on guaranteed offsets - Remove 8 always-true instanceof checks - Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount) - Simplify 6 unnecessary nullsafe operators (?-> → ->) - Fix 6 always-true !== '' comparisons - Fix remaining: unset.offset, return.unusedType, staticMethod narrowing 53 files changed across core/, modules/, pages/, and tests/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
81 lines
2.4 KiB
PHP
81 lines
2.4 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Service\Ui;
|
|
|
|
use MintyPHP\Service\Ui\HotkeyService;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class HotkeyServiceTest extends TestCase
|
|
{
|
|
public function testListReturnsNonEmptyArray(): void
|
|
{
|
|
$result = HotkeyService::list();
|
|
|
|
$this->assertNotEmpty($result);
|
|
}
|
|
|
|
public function testListEntriesHaveRequiredKeys(): void
|
|
{
|
|
$result = HotkeyService::list();
|
|
|
|
foreach ($result as $index => $entry) {
|
|
$this->assertArrayHasKey('action_key', $entry, "Entry #{$index} is missing 'action_key'");
|
|
$this->assertArrayHasKey('mac', $entry, "Entry #{$index} is missing 'mac'");
|
|
$this->assertArrayHasKey('win', $entry, "Entry #{$index} is missing 'win'");
|
|
$this->assertNotEmpty($entry['action_key'], "Entry #{$index} has empty 'action_key'");
|
|
$this->assertNotEmpty($entry['mac'], "Entry #{$index} has empty 'mac'");
|
|
$this->assertNotEmpty($entry['win'], "Entry #{$index} has empty 'win'");
|
|
}
|
|
}
|
|
|
|
public function testListEntriesHaveExactlyThreeKeys(): void
|
|
{
|
|
$result = HotkeyService::list();
|
|
|
|
foreach ($result as $index => $entry) {
|
|
$this->assertCount(3, $entry, "Entry #{$index} should have exactly 3 keys");
|
|
}
|
|
}
|
|
|
|
public function testSearchKeywordsReturnsNonEmptyArray(): void
|
|
{
|
|
$result = HotkeyService::searchKeywords();
|
|
|
|
$this->assertNotEmpty($result);
|
|
}
|
|
|
|
public function testSearchKeywordsContainsExpectedTerms(): void
|
|
{
|
|
$result = HotkeyService::searchKeywords();
|
|
|
|
$this->assertContains('hotkey', $result);
|
|
$this->assertContains('shortcut', $result);
|
|
$this->assertContains('keyboard', $result);
|
|
}
|
|
|
|
public function testSearchKeywordsAreAllStrings(): void
|
|
{
|
|
$result = HotkeyService::searchKeywords();
|
|
|
|
foreach ($result as $keyword) {
|
|
$this->assertNotEmpty($keyword);
|
|
}
|
|
}
|
|
|
|
public function testListReturnsDeterministicResult(): void
|
|
{
|
|
$first = HotkeyService::list();
|
|
$second = HotkeyService::list();
|
|
|
|
$this->assertSame($first, $second);
|
|
}
|
|
|
|
public function testSearchKeywordsReturnsDeterministicResult(): void
|
|
{
|
|
$first = HotkeyService::searchKeywords();
|
|
$second = HotkeyService::searchKeywords();
|
|
|
|
$this->assertSame($first, $second);
|
|
}
|
|
}
|