fs
06118c1b26
The "Last run" KPI tile stayed empty after a manual policy run, even
though the run completed successfully. Two distinct bugs were
involved:
1. The dashboard read latestSystemRun() from the audit log filtered by
trigger_type='system'. UserLifecycleService::run() never sets that
value — it uses 'manual' for actor-triggered runs and 'cron' for
scheduled ones. The query never matched anything.
2. Even with the right trigger_type, the audit log only writes per-user
entries (logDeactivate / logDelete / logDeleteFailure). A run that
processes zero users — including most cron ticks on a healthy
tenant — leaves no trace, so the tile would still show "—" after a
correct execution.
Both bugs share one root cause: run-trigger state was being inferred
from audit-log details, but those are two semantically different
things. Audit log answers "what did the run do?". A "last run" tile
answers "did the run happen?".
This commit moves run-trigger state to the core settings table and
keeps the audit log strictly for per-user events:
* Two new keys in core/Service/Settings/SettingKeys —
USER_LIFECYCLE_LAST_RUN_AT_KEY and USER_LIFECYCLE_LAST_RUN_STATUS_KEY.
* SettingsUserLifecycleGateway gains recordLastRun() and getLastRun().
UserSettingsGateway exposes them as recordLifecycleLastRun() /
getLifecycleLastRun() so UserLifecycleService can call through its
existing dependency without growing its constructor.
* UserLifecycleService::run() writes both keys in finally — every time
the lock was acquired, regardless of whether any user was processed
and regardless of whether the run finished cleanly. Status reflects
$result['ok'] ('success' / 'failed').
* UserLifecyclePolicyDashboardService gains a lastRun() reader. Action
page now sources the KPI tile from this core service instead of the
audit interface — so the tile works even when the audit module is
disabled.
* The audit-side lastRun() / latestSystemRun() / their tests are
removed (YAGNI). Phase 4 (activity feed) can rebuild from the audit
filter grid without a special method.
Behaviorally: a no-op run now records "Last run: just now · ✓ Success"
in the cockpit, exactly as expected.
All six quality gates green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
93 lines
3.6 KiB
PHP
93 lines
3.6 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Service\User;
|
|
|
|
use MintyPHP\Repository\User\UserLifecyclePolicyDashboardRepositoryInterface;
|
|
use MintyPHP\Service\User\UserLifecyclePolicyDashboardService;
|
|
use MintyPHP\Service\User\UserSettingsGateway;
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class UserLifecyclePolicyDashboardServiceTest extends TestCase
|
|
{
|
|
private function service(
|
|
?UserLifecyclePolicyDashboardRepositoryInterface $repository = null,
|
|
?UserSettingsGateway $settingsGateway = null
|
|
): UserLifecyclePolicyDashboardService {
|
|
return new UserLifecyclePolicyDashboardService(
|
|
$repository ?? $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class),
|
|
$settingsGateway ?? $this->createMock(UserSettingsGateway::class)
|
|
);
|
|
}
|
|
|
|
public function testReturnsZeroWhenDeactivateDaysIsZero(): void
|
|
{
|
|
$repository = $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class);
|
|
$repository->expects($this->never())->method('countPendingDeletion');
|
|
|
|
$this->assertSame(0, $this->service($repository)->pendingDeletionCount(0, 365, 7));
|
|
}
|
|
|
|
public function testReturnsZeroWhenDeleteDaysIsZero(): void
|
|
{
|
|
$repository = $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class);
|
|
$repository->expects($this->never())->method('countPendingDeletion');
|
|
|
|
$this->assertSame(0, $this->service($repository)->pendingDeletionCount(180, 0, 7));
|
|
}
|
|
|
|
public function testReturnsZeroWhenWindowDaysIsZeroOrNegative(): void
|
|
{
|
|
$repository = $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class);
|
|
$repository->expects($this->never())->method('countPendingDeletion');
|
|
|
|
$service = $this->service($repository);
|
|
|
|
$this->assertSame(0, $service->pendingDeletionCount(180, 365, 0));
|
|
$this->assertSame(0, $service->pendingDeletionCount(180, 365, -1));
|
|
}
|
|
|
|
public function testDelegatesToRepositoryWhenAllPolicyValuesPositive(): void
|
|
{
|
|
$repository = $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class);
|
|
$repository->expects($this->once())
|
|
->method('countPendingDeletion')
|
|
->with(365, 7)
|
|
->willReturn(42);
|
|
|
|
$this->assertSame(42, $this->service($repository)->pendingDeletionCount(180, 365, 7));
|
|
}
|
|
|
|
public function testReturnsRepositoryCountVerbatim(): void
|
|
{
|
|
$repository = $this->createMock(UserLifecyclePolicyDashboardRepositoryInterface::class);
|
|
$repository->method('countPendingDeletion')->willReturn(0);
|
|
|
|
$this->assertSame(0, $this->service($repository)->pendingDeletionCount(180, 365, 7));
|
|
}
|
|
|
|
public function testLastRunReturnsNullWhenSettingsHaveNoRecord(): void
|
|
{
|
|
$settingsGateway = $this->createMock(UserSettingsGateway::class);
|
|
$settingsGateway->expects($this->once())
|
|
->method('getLifecycleLastRun')
|
|
->willReturn(null);
|
|
|
|
$this->assertNull($this->service(null, $settingsGateway)->lastRun());
|
|
}
|
|
|
|
public function testLastRunReturnsRecordedSettingsVerbatim(): void
|
|
{
|
|
$settingsGateway = $this->createMock(UserSettingsGateway::class);
|
|
$settingsGateway->method('getLifecycleLastRun')->willReturn([
|
|
'created_at' => '2026-04-26 17:30:00',
|
|
'status' => 'success',
|
|
]);
|
|
|
|
$row = $this->service(null, $settingsGateway)->lastRun();
|
|
|
|
$this->assertIsArray($row);
|
|
$this->assertSame('2026-04-26 17:30:00', $row['created_at']);
|
|
$this->assertSame('success', $row['status']);
|
|
}
|
|
}
|