fs
c429ff43cd
- Add user-assignment dependency check to DepartmentService.deleteByUuid (409 when users assigned)
- Standardize POST detection to isMethod('POST') in 10 create/edit actions
- Align RoleService code uniqueness to warning pattern (matching departments)
- Normalize repository create() return types from mixed to int|false (3 repos + 3 interfaces)
- Add JSON response branches to 4 non-user delete actions
- Document delete authorization ordering pattern
- Decompose AdminSettingsService.updateFromAdmin into domain-scoped private methods
Workflow: .agents/runs/CRUD-CONSISTENCY-001/
Reviewed by: Code Reviewer (pass), Security Reviewer (pass), Acceptance Tester (pass)
Quality gates: QG-001 PHPUnit pass, QG-002 PHPStan pass, QG-003 Architecture pass
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
69 lines
2.3 KiB
PHP
69 lines
2.3 KiB
PHP
<?php
|
|
|
|
use MintyPHP\Buffer;
|
|
use MintyPHP\Http\SessionStoreInterface;
|
|
use MintyPHP\Router;
|
|
use MintyPHP\Service\Access\PermissionAuthorizationPolicy;
|
|
use MintyPHP\Session;
|
|
use MintyPHP\Support\Flash;
|
|
use MintyPHP\Support\Guard;
|
|
|
|
$session = app(SessionStoreInterface::class)->all();
|
|
Guard::requireLogin();
|
|
$request = requestInput();
|
|
$returnTarget = requestResolveReturnTarget();
|
|
$closeTarget = requestResolveReturnTarget('admin/permissions');
|
|
$createTarget = requestPathWithReturnTarget('admin/permissions/create', $returnTarget);
|
|
|
|
$currentUserId = (int) ($session['user']['id'] ?? 0);
|
|
$authorizationService = app(\MintyPHP\Service\Access\AuthorizationService::class);
|
|
$decision = $authorizationService->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_CREATE, [
|
|
'actor_user_id' => $currentUserId,
|
|
]);
|
|
if (!$decision->isAllowed()) {
|
|
Guard::deny();
|
|
}
|
|
|
|
$errorBag = formErrors();
|
|
$errors = [];
|
|
$form = [
|
|
'key' => '',
|
|
'description' => '',
|
|
'active' => 1,
|
|
'is_system' => 0,
|
|
];
|
|
|
|
if ($request->isMethod('POST') && !Session::checkCsrfToken()) {
|
|
Flash::error(t('Form expired, please try again'), $createTarget, 'csrf_expired');
|
|
Router::redirect($createTarget);
|
|
return;
|
|
}
|
|
|
|
if ($request->isMethod('POST')) {
|
|
$result = app(\MintyPHP\Service\Access\PermissionService::class)->createFromAdmin($request->bodyAll());
|
|
$form = $result['form'] ?? $form;
|
|
$errorBag->merge($result['errors'] ?? []);
|
|
|
|
if (($result['ok'] ?? false) && !$errorBag->hasAny()) {
|
|
$action = (string) $request->body('action', 'create');
|
|
if ($action === 'create_close') {
|
|
Flash::success('Permission created', $closeTarget, 'permission_created');
|
|
Router::redirect($closeTarget);
|
|
} else {
|
|
$id = (int) ($result['id'] ?? 0);
|
|
if ($id > 0) {
|
|
$target = requestPathWithReturnTarget("admin/permissions/edit/{$id}", $returnTarget);
|
|
Flash::success('Permission created', $target, 'permission_created');
|
|
Router::redirect($target);
|
|
} else {
|
|
Flash::success('Permission created', $closeTarget, 'permission_created');
|
|
Router::redirect($closeTarget);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
$validationSummaryErrors = $errorBag->toArray();
|
|
$errors = $errorBag->toFlatList();
|
|
Buffer::set('title', t('Create permission'));
|