fs
0c351f6aff
Move the entire audit subsystem (system audit, API audit, import audit, user lifecycle audit, frontend telemetry) from core into modules/audit/. Core decoupling via interface-based injection: - AuditRecorderInterface replaces SystemAuditService in 10+ core services - UserLifecycleAuditInterface / ImportAuditInterface for specialized flows - NullAuditRecorder fallback when audit module is disabled - ApiBootstrap/ApiResponse use null-safe callable resolvers Module structure (modules/audit/): - Manifest with routes, permissions, scheduler jobs, authorization policy - 9 services, 8 repositories, 6 domain enums, 4 job handlers - 33 page files, 4 JS files, 8 test files, migration scripts, i18n Core cleanup: - OperationsAuthorizationPolicy, UiCapabilityMap, PermissionService surgically cleaned of audit-specific constants - Sidebar template cleared of hardcoded audit navigation - AuditModuleIsolationContractTest ensures no future core→module coupling All quality gates pass: 1346 tests (19,276 assertions), PHPStan level 5 clean, architecture contracts verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
52 lines
2.2 KiB
PHP
52 lines
2.2 KiB
PHP
<?php
|
|
|
|
namespace MintyPHP\Tests\Architecture;
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
class AuthzUiLayoutContractTest extends TestCase
|
|
{
|
|
use ProjectFileAssertionSupport;
|
|
|
|
public function testLayoutPartialsUseViewAuthLayoutCapabilities(): void
|
|
{
|
|
$defaultTemplate = $this->readProjectFile('templates/default.phtml');
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $defaultTemplate);
|
|
$this->assertStringNotContainsString('UiAccessService::class', $defaultTemplate);
|
|
|
|
$aside = $this->readProjectFile('templates/partials/app-main-aside.phtml');
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $aside);
|
|
$this->assertStringContainsString('layoutHasAdminPanel(', $aside);
|
|
$this->assertStringContainsString('$layoutNav', $aside);
|
|
|
|
$iconBar = $this->readProjectFile('templates/partials/app-main-aside-icon-bar.phtml');
|
|
$this->assertStringContainsString("\$viewAuth['layout']", $iconBar);
|
|
$this->assertStringContainsString('layoutHasAdminPanel(', $iconBar);
|
|
}
|
|
|
|
public function testAsideTemplateDoesNotReadRequestOrResolveServicesDirectly(): void
|
|
{
|
|
$aside = $this->readProjectFile('templates/partials/app-main-aside.phtml');
|
|
|
|
$this->assertStringNotContainsString('$_GET', $aside);
|
|
$this->assertStringNotContainsString('$_SESSION', $aside);
|
|
$this->assertStringNotContainsString('TenantAvatarService', $aside);
|
|
$this->assertStringNotContainsString('app(', $aside);
|
|
}
|
|
|
|
public function testUiAccessServiceUsesCentralLayoutMapDefinition(): void
|
|
{
|
|
$content = $this->readProjectFile('lib/Service/Access/UiAccessService.php');
|
|
$this->assertStringContainsString('UiCapabilityMap::LAYOUT', $content);
|
|
}
|
|
|
|
public function testCoreCapabilityMapDoesNotHardcodeAuditCapabilities(): void
|
|
{
|
|
$content = $this->readProjectFile('lib/Service/Access/UiCapabilityMap.php');
|
|
$this->assertStringNotContainsString('can_view_system_audit', $content);
|
|
$this->assertStringNotContainsString('can_view_api_audit', $content);
|
|
$this->assertStringNotContainsString('can_view_user_lifecycle_audit', $content);
|
|
$this->assertStringNotContainsString('can_view_imports_audit', $content);
|
|
}
|
|
}
|