fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
Files
49078f18535015a50613ce9295b6ce1489384bec
breadcrumb-the-shire/tests/Architecture
History
fs 3f0db68b27 refactor: fix all 105 PHPStan 2 strict type findings across core and modules 
Resolve all non-false-positive PHPStan 2 findings, reducing the baseline
from 486 to 382 entries (only unused-public false positives remain).

Categories fixed:
- Remove 39 redundant type checks (is_string, is_array, is_object, method_exists)
- Remove 12 no-op array_values() on already-sequential lists
- Simplify 13 null-coalesce on guaranteed offsets
- Remove 8 always-true instanceof checks
- Replace 12 redundant test assertions (assertTrue(true) → addToAssertionCount)
- Simplify 6 unnecessary nullsafe operators (?-> → ->)
- Fix 6 always-true !== '' comparisons
- Fix remaining: unset.offset, return.unusedType, staticMethod narrowing

53 files changed across core/, modules/, pages/, and tests/.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-14 12:54:20 +02:00
..
AbstractModuleRegistryContractTestCase.php
Split module registry contracts
2026-03-19 19:00:29 +01:00
AbstractModuleStructureContractTestCase.php
Split module structure contracts
2026-03-19 18:30:14 +01:00
AddressBookModuleIsolationContractTest.php
fix: patch remaining lib/ references missed in core/ rename
2026-04-14 07:54:02 +02:00
AgentSystemCatalogContractTest.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
AgentSystemContractSupport.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
AgentSystemEnforcementContractTest.php
feat(helpdesk): redesign dashboards with KPI groups, skeleton loading, and unified spacing
2026-04-05 16:32:34 +02:00
AgentSystemFileContractTest.php
chore(agents): implement v2 hardening and enforcement-ready QA
2026-04-01 19:41:56 +02:00
AgentSystemReferenceContractTest.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
ApiResourceContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
ApiSchemaContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
ApiSessionIsolationContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
AppContainerIsolationContractTest.php
feat: extend module platform with UI slots, runtime components, CLI tooling and {{userId}} search support
2026-03-18 22:19:56 +01:00
AsideNavigationAdminContractTest.php
feat(helpdesk): refactor multi-tenant BC settings and risk radar improvements
2026-04-06 22:22:17 +02:00
AsideNavigationRuntimeContractTest.php
Split aside navigation contracts
2026-03-19 19:13:51 +01:00
AssetVersioningContractTest.php
test: add architecture contract tests for layering, sessions, and asset versioning
2026-03-22 14:15:41 +01:00
AuditModuleIsolationContractTest.php
fix: patch remaining lib/ references missed in core/ rename
2026-04-14 07:54:02 +02:00
AuthHelpLinksContractFiles.php
Split auth help link contracts
2026-03-19 19:05:29 +01:00
AuthHelpLinksPageContractTest.php
Split auth help link contracts
2026-03-19 19:05:29 +01:00
AuthHelpLinksPartialContractTest.php
Split auth help link contracts
2026-03-19 19:05:29 +01:00
AuthLoginAccessibilityContractFiles.php
Split auth login accessibility contracts
2026-03-19 19:12:25 +01:00
AuthLoginFieldAccessibilityContractTest.php
Split auth login accessibility contracts
2026-03-19 19:12:25 +01:00
AuthLoginPasswordToggleContractTest.php
Split auth login accessibility contracts
2026-03-19 19:12:25 +01:00
AuthLoginTemplateAccessibilityContractTest.php
Split auth login accessibility contracts
2026-03-19 19:12:25 +01:00
AuthLoginTenantSelectionContractTest.php
Split auth login accessibility contracts
2026-03-19 19:12:25 +01:00
AuthzAdminMasterDataContractTest.php
Refactor architecture test contracts
2026-03-19 18:25:19 +01:00
AuthzAdminSettingsContractTest.php
Refactor architecture test contracts
2026-03-19 18:25:19 +01:00
AuthzAdminTenantsContractTest.php
Refactor architecture test contracts
2026-03-19 18:25:19 +01:00
AuthzAdminUsersContractTest.php
Refactor architecture test contracts
2026-03-19 18:25:19 +01:00
AuthzApiBootstrapContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
AuthzUiActionContractTest.php
fix(audit): restructure module pages to avoid admin/ path collision
2026-03-26 08:13:37 +01:00
AuthzUiContractSupport.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
AuthzUiLayoutContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
AuthzUiTemplateContractTest.php
fix(audit): restructure module pages to avoid admin/ path collision
2026-03-26 08:13:37 +01:00
BookmarksModuleIsolationContractTest.php
fix: patch remaining lib/ references missed in core/ rename
2026-04-14 07:54:02 +02:00
CodexAutomationContractTest.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
CodexDocsContractSupport.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
CodexDocsIntegrityContractTest.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
CodexSkillReferenceContractTest.php
Split meta architecture contracts
2026-03-19 18:52:36 +01:00
ConfigContractsTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
ContainerFactoryContractTest.php
refactor(audit): remove factory chain and repository interfaces
2026-03-26 12:33:59 +01:00
CoreStarterkitContractTest.php
fix: patch remaining lib/ references missed in core/ rename
2026-04-14 07:54:02 +02:00
CoreTemplateIsolationTest.php
feat: extend module platform with UI slots, runtime components, CLI tooling and {{userId}} search support
2026-03-18 22:19:56 +01:00
DatabaseUpdatesContractTest.php
fix(security): add CSRF protection to all POST endpoints + contract tests (B2)
2026-03-10 15:40:07 +01:00
DetailActionPolicyContractFiles.php
Split detail action policy contracts
2026-03-19 19:03:10 +01:00
DetailActionPolicyMigrationContractTest.php
Split detail action policy contracts
2026-03-19 19:03:10 +01:00
DetailActionPolicyPartialContractTest.php
Split detail action policy contracts
2026-03-19 19:03:10 +01:00
DetailActionPolicyRuntimeContractTest.php
Split detail action policy contracts
2026-03-19 19:03:10 +01:00
DetailPageContractFiles.php
Split detail page contracts
2026-03-19 19:04:28 +01:00
DetailPageFormContractTest.php
Split detail page contracts
2026-03-19 19:04:28 +01:00
DetailPageRuntimeContractTest.php
Split detail page contracts
2026-03-19 19:04:28 +01:00
DetailPageTitlebarContractTest.php
Split detail page contracts
2026-03-19 19:04:28 +01:00
DetailValidationActionContractTest.php
Split detail validation contracts
2026-03-19 19:02:04 +01:00
DetailValidationAssetContractTest.php
Split detail validation contracts
2026-03-19 19:02:04 +01:00
DetailValidationContractFiles.php
Split detail validation contracts
2026-03-19 19:02:04 +01:00
DetailValidationTemplateContractTest.php
Split detail validation contracts
2026-03-19 19:02:04 +01:00
FileStorageContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
FilterDrawerRuntimeContractTest.php
chore: remove legacy tools/codex-skills (moved to .agents/skills), split filter drawer tests, clean up stale docs
2026-03-19 19:59:08 +01:00
FilterDrawerTemplateContractTest.php
chore: remove legacy tools/codex-skills (moved to .agents/skills), split filter drawer tests, clean up stale docs
2026-03-19 19:59:08 +01:00
FrontendRuntimeComponentContractTest.php
feat(helpdesk): refactor multi-tenant BC settings and risk radar improvements
2026-04-06 22:22:17 +02:00
FrontendRuntimeContractSupport.php
feat: centralize breadcrumbs in topbar and remove history navigation
2026-04-05 17:17:06 +02:00
FrontendRuntimeEntrypointContractTest.php
Split frontend runtime contracts
2026-03-19 18:34:02 +01:00
FrontendRuntimeHostContractTest.php
feat: centralize breadcrumbs in topbar and remove history navigation
2026-04-05 17:17:06 +02:00
FrontendTelemetryContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
I18nKeyCompletenessContractTest.php
chore(agents): implement v2 hardening and enforcement-ready QA
2026-04-01 19:41:56 +02:00
ListActionContractTest.php
Refactor architecture test contracts
2026-03-19 18:25:19 +01:00
ListContractFiles.php
feat(helpdesk): add dashboards, communication feed, settings UI and fix routing
2026-04-04 18:34:03 +02:00
ListDataEndpointContractTest.php
feat(helpdesk): align module with core list/drawer standards
2026-04-02 17:48:27 +02:00
ListTemplateContractTest.php
refactor(tests): remove redundant tests and fix assertion style
2026-03-25 18:46:49 +01:00
ListTitlebarContractFiles.php
fix(audit): restructure module pages to avoid admin/ path collision
2026-03-26 08:13:37 +01:00
ListTitlebarTemplateContractTest.php
Split list titlebar contracts
2026-03-19 19:29:45 +01:00
ListUiSharedPartialsContractTest.php
fix(audit): restructure module pages to avoid admin/ path collision
2026-03-26 08:13:37 +01:00
ModuleBoundaryContractTest.php
Split module structure contracts
2026-03-19 18:30:14 +01:00
ModuleExtractionContractSupport.php
Rename module extraction contracts
2026-03-19 18:57:03 +01:00
ModuleI18nContractTest.php
chore(agents): implement v2 hardening and enforcement-ready QA
2026-04-01 19:41:56 +02:00
ModuleManifestContractTest.php
refactor: fix all 105 PHPStan 2 strict type findings across core and modules
2026-04-14 12:54:20 +02:00
ModuleManifestSchemaValidationContractTest.php
chore(agents): implement v2 hardening and enforcement-ready QA
2026-04-01 19:41:56 +02:00
ModuleProviderContractTest.php
Split module structure contracts
2026-03-19 18:30:14 +01:00
ModuleRegistryBootstrapContractTest.php
refactor(addressbook): move from aside icon-bar to explorer nav link
2026-03-26 15:06:15 +01:00
ModuleRegistryFailFastContractTest.php
Split module registry contracts
2026-03-19 19:00:29 +01:00
ModuleSessionKeyPrefixContractTest.php
test: add architecture contract tests for layering, sessions, and asset versioning
2026-03-22 14:15:41 +01:00
ModuleUiContractTest.php
refactor: fix all 105 PHPStan 2 strict type findings across core and modules
2026-04-14 12:54:20 +02:00
PostEndpointCsrfContractTest.php
fix(security): add CSRF protection to all POST endpoints + contract tests (B2)
2026-03-10 15:40:07 +01:00
PostRedirectGetContractTest.php
feat(tests): automate 5 remaining guards as contract tests
2026-03-10 21:20:08 +01:00
ProjectFileAssertionSupport.php
feat(tests): automate 5 remaining guards as contract tests
2026-03-10 21:20:08 +01:00
PublicPageAdminContractTest.php
Split public page contracts
2026-03-19 18:48:16 +01:00
PublicPageRoutingContractTest.php
Split public page contracts
2026-03-19 18:48:16 +01:00
RepositoryInterfaceContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
RepositoryLayerIsolationContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
SecurityCryptoContractTest.php
fix: patch remaining lib/ references missed in core/ rename
2026-04-14 07:54:02 +02:00
SecurityLoggingRedactionContractTest.php
feat(audit): harden API audit log redaction and schema
2026-04-05 23:20:55 +02:00
SecurityLoggingRuntimeContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
SecurityLoggingTelemetryContractTest.php
refactor(audit): extract audit domain into self-contained module
2026-03-25 21:12:49 +01:00
SecurityRemoteAssetContractTest.php
chore(agents): implement v2 hardening and enforcement-ready QA
2026-04-01 19:41:56 +02:00
ServiceLayerNoHtmlContractTest.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
StatusTaxonomyContractFiles.php
refactor: rename lib/ to core/ for clearer core-module separation
2026-04-13 23:20:42 +02:00
StatusTaxonomyDataContractTest.php
Split status taxonomy contracts
2026-03-19 19:11:03 +01:00
StatusTaxonomyEnumContractTest.php
Split status taxonomy contracts
2026-03-19 19:11:03 +01:00
StatusTaxonomyFilterSchemaContractTest.php
Split status taxonomy contracts
2026-03-19 19:11:03 +01:00
StatusTaxonomyLiteralGuardContractTest.php
Split status taxonomy contracts
2026-03-19 19:11:03 +01:00
StatusTaxonomyUiContractTest.php
fix(audit): restructure module pages to avoid admin/ path collision
2026-03-26 08:13:37 +01:00
TypographyTokenContractTest.php
feat: add developer error page with request ID tracking and structured logging
2026-03-24 20:49:22 +01:00
ViewLayerNoDbCallsContractTest.php
test: add architecture contract tests for layering, sessions, and asset versioning
2026-03-22 14:15:41 +01:00
ViewLayerOutputEscapingContractTest.php
feat(guards): add GR-SEC-010 — output escaping enforcement in views
2026-04-06 12:08:25 +02:00