fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
Files
0e869254649889619fbe800487f109f247bdecd6
breadcrumb-the-shire/.agents/skills/core-guardrails/references/quality-gates.md
fs 0e86925464 refactor: rename lib/ to core/ for clearer core-module separation 
Rename the top-level lib/ directory to core/ so the project root
immediately communicates which code is core platform and which lives
in modules/. PHP namespaces (MintyPHP\*) are unchanged — only the
Composer PSR-4 path mapping moves from lib/ to core/.

Module-internal lib/ directories (modules/*/lib/) are untouched.

Updated across the full stack:
- composer.json PSR-4 mapping
- bootstrap entry points (web/index.php, bin/*, tests/bootstrap.php)
- tooling configs (phpstan.neon, phpunit.xml, php-cs-fixer)
- 26 architecture contract tests
- enforcement-policy, guard-catalog, quality-gates
- all documentation (CLAUDE.md, README, 25 docs/, .agents/skills/)
- bin/qa-extended.sh search paths
- .claude/settings.local.json permission paths

Workflow: .agents/runs/CORE-LIB-RENAME-001/ (Analyst → Planner →
Executor → Code Review (4 findings fixed) → Security Review →
Acceptance Test → Finalizer)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-13 23:20:42 +02:00

2.2 KiB
Raw Blame History

Quality Gates

Pflicht-Gates

  1. docker compose exec php vendor/bin/phpunit
  2. docker compose exec php vendor/bin/phpstan analyse -c phpstan.neon --no-progress
  3. docker compose exec php vendor/bin/phpunit tests/Architecture/CoreStarterkitContractTest.php
  4. docker compose exec php vendor/bin/php-cs-fixer fix --config=tools/php-cs-fixer/.php-cs-fixer.dist.php --dry-run --diff --verbose
  5. bin/docs-link-check.sh
  6. bin/codex-skills-sync.sh --check

Policy-Hinweis:

  • Verbindliche Enforcement-Einteilung (required, manual_non_blocking, periodic_non_blocking) wird zentral in /.agents/checks/enforcement-policy.json gepflegt.

Struktur-Gates (schnell)

(rg 'new\s+[^\s(]+Factory\(' core/Service || true) | wc -l
(rg --glob '!**/*Factory.php' 'new\s+[^\s(]+(Service|Gateway|Repository)\(' core/Service || true) | wc -l
(rg "\b(accessServicesFactory|directoryServicesFactory|userServicesFactory|authServicesFactory|tenantServicesFactory|settingServicesFactory|userRepositoryFactory|authRepositoryFactory|authGatewayFactory)\(" pages core templates web || true) | wc -l
(rg -n 'new\s+[^\s(]+(Service|Gateway|Repository)\(' pages -g '*.php' || true) | wc -l
(rg -n '\bDB::' pages -g '*.php' || true) | wc -l
(rg -n 'app\([^\n]*Factory::class\)->create' pages/admin -g '*.php' || true) | wc -l
(rg -n 'Factory::class' pages/admin -g '*.php' || true) | wc -l
(rg -n 'ApiResponse::readJsonBody\(' pages/api/v1 -g '*.php' || true) | wc -l

Erwartung: jeweils 0.

JS-Scope

  • Bei JS-Aenderungen Browser-Smoke mit DevTools-Console durchfuehren.
  • Erwartung: keine neuen JS-Errors.

Docs-/Skills-Gates (schnell)

  1. bin/docs-link-check.sh
    • prueft Doku-Links in README.md, docs/**, .agents/skills/** und .agents/**
    • .agents/runs/** ist standardmaessig ausgeschlossen (historische Artefakte)
  2. bin/docs-drift-check.sh
    • prueft bekannte Legacy-Drifts (entfernte Config-Pfade/Constants, obsolete Search-Marker)
    • prueft Setup-Vertrag fuer config/config.php.example in den Kern-Onboarding-Dokus
  3. bin/codex-skills-sync.sh --check
    • prueft Drift zwischen Repo-Skills und ~/.codex/skills

Berichtspflicht

  • Bei jedem Gate klar angeben: passed / failed / not run.
  • Bei failed den blocker explizit benennen.
Reference in New Issue View Git Blame Copy Permalink