fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: module architecture improvements — session keys, dependency graph, event dispatcher, deactivation hooks

Browse Source 
Six targeted improvements to the modular monolith platform:

1. Fix AddressBook session key prefix to follow module.<id>.* convention
2. Move ADDRESS_BOOK_VIEW permission constant from core PermissionService into module
3. Add declarative JSON schema for module manifests (.agents/contracts/)
4. Add `requires` field with missing-dependency and circular-dependency detection
5. Add lightweight fire-and-forget event dispatcher (user.created/deleted/login/logout)
6. Add module deactivation hook interface and CLI script (bin/module-deactivate.php)

Includes 15 new architecture/unit tests covering all new functionality.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-19 18:20:13 +01:00
parent 866d43e15a
commit ef72b34c40
31 changed files with 1041 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/addressbook/lib/Module/AddressBook/AddressBookAuthorizationPolicy.php
View File

@@ -15,6 +15,7 @@ use MintyPHP\Service\Access\PermissionService;
final class AddressBookAuthorizationPolicy implements AuthorizationPolicyInterface
{
public const ABILITY_VIEW = 'addressbook.view';
public const PERMISSION_KEY = 'address_book.view';
public function __construct(
private readonly PermissionService $permissionService
@@ -33,7 +34,7 @@ final class AddressBookAuthorizationPolicy implements AuthorizationPolicyInterfa
return AuthorizationDecision::deny(403, 'forbidden');
}
if (!$this->permissionService->userHas($actorUserId, PermissionService::ADDRESS_BOOK_VIEW)) {
if (!$this->permissionService->userHas($actorUserId, self::PERMISSION_KEY)) {
return AuthorizationDecision::deny(403, 'forbidden');
}

4
modules/addressbook/lib/Module/AddressBook/Providers/AddressBookLayoutProvider.php
View File

@@ -31,8 +31,8 @@ final class AddressBookLayoutProvider implements LayoutContextProvider
'activeDepartments' => appNormalizePositiveIntList($query['departments'] ?? ''),
'activeRoles' => appNormalizePositiveIntList($query['roles'] ?? ''),
'activeCustomFilters' => self::normalizeCustomFilterQuery($query),
'peopleGroups' => is_array($session['available_departments_by_tenant'] ?? null)
? $session['available_departments_by_tenant']
'peopleGroups' => is_array($session['module.addressbook.departments_by_tenant'] ?? null)
? $session['module.addressbook.departments_by_tenant']
: [],
],
];

6
modules/addressbook/lib/Module/AddressBook/Providers/AddressBookSessionProvider.php
View File

@@ -17,7 +17,7 @@ final class AddressBookSessionProvider implements SessionProvider
{
$userId = (int) ($user['id'] ?? 0);
if ($userId <= 0) {
unset($_SESSION['available_departments_by_tenant']);
unset($_SESSION['module.addressbook.departments_by_tenant']);
return;
}
@@ -28,13 +28,13 @@ final class AddressBookSessionProvider implements SessionProvider
}
$sessionStore->set(
'available_departments_by_tenant',
'module.addressbook.departments_by_tenant',
$tenantContext->getAvailableDepartmentsByTenant($userId)
);
}
public function clear(): void
{
unset($_SESSION['available_departments_by_tenant']);
unset($_SESSION['module.addressbook.departments_by_tenant']);
}
}