From d6835d3b7b03ba3a7020bd9a8d509a291882c8a1 Mon Sep 17 00:00:00 2001
From: fs <fs@breadcrumb-solutions.de>
Date: Sun, 5 Apr 2026 22:01:50 +0200
Subject: [PATCH] fix(helpdesk): remove contracts KPI section from support
 dashboard

The Contracts & products KPI tiles (active contracts, monthly volume,
support hours, next invoicing) distract from the ticket-focused support
view. Contract data remains available in the dedicated Sales tab.

Removes: section HTML, skeleton placeholder, JS render function + call.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../pages/helpdesk/debitor(default).phtml     | 36 ----------
 modules/helpdesk/web/js/helpdesk-detail.js    | 67 -------------------
 2 files changed, 103 deletions(-)

diff --git a/modules/helpdesk/pages/helpdesk/debitor(default).phtml b/modules/helpdesk/pages/helpdesk/debitor(default).phtml
index 6951994..19305ad 100644
--- a/modules/helpdesk/pages/helpdesk/debitor(default).phtml
+++ b/modules/helpdesk/pages/helpdesk/debitor(default).phtml
@@ -85,16 +85,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
         <!-- Support panel -->
         <div data-tab-panel="support">
           <div id="support-loading">
-            <div class="helpdesk-support-metrics">
-              <?php for ($i = 0; $i < 4; $i++): ?>
-                <div class="helpdesk-skeleton-kpi">
-                  <div class="helpdesk-skeleton helpdesk-skeleton-kpi-label"></div>
-                  <div class="helpdesk-skeleton helpdesk-skeleton-kpi-value"></div>
-                  <div class="helpdesk-skeleton helpdesk-skeleton-kpi-trend"></div>
-                </div>
-              <?php endfor; ?>
-            </div>
-            <div class="helpdesk-skeleton-divider"></div>
             <div class="helpdesk-support-metrics">
               <?php for ($i = 0; $i < 4; $i++): ?>
                 <div class="helpdesk-skeleton-kpi">
@@ -141,32 +131,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
               </div>
             </section>
 
-            <section id="support-contract-kpis-wrapper" hidden>
-              <h3 class="helpdesk-support-section-title"><?php e(t('Contracts & products')); ?></h3>
-              <div class="helpdesk-support-metrics" id="support-contract-kpis">
-                <article class="helpdesk-support-metric">
-                  <p class="helpdesk-support-metric-label"><?php e(t('Active contracts')); ?></p>
-                  <p class="helpdesk-support-metric-value" id="support-kpi-active-contracts">—</p>
-                  <p class="helpdesk-support-metric-trend" id="support-kpi-active-contracts-trend"></p>
-                </article>
-                <article class="helpdesk-support-metric">
-                  <p class="helpdesk-support-metric-label"><?php e(t('Monthly volume')); ?></p>
-                  <p class="helpdesk-support-metric-value" id="support-kpi-monthly-volume">—</p>
-                  <p class="helpdesk-support-metric-trend" id="support-kpi-monthly-volume-trend"></p>
-                </article>
-                <article class="helpdesk-support-metric">
-                  <p class="helpdesk-support-metric-label"><?php e(t('Support hours')); ?></p>
-                  <p class="helpdesk-support-metric-value" id="support-kpi-support-hours">—</p>
-                  <p class="helpdesk-support-metric-trend" id="support-kpi-support-hours-trend"></p>
-                </article>
-                <article class="helpdesk-support-metric">
-                  <p class="helpdesk-support-metric-label"><?php e(t('Next invoicing')); ?></p>
-                  <p class="helpdesk-support-metric-value" id="support-kpi-next-invoicing">—</p>
-                  <p class="helpdesk-support-metric-trend" id="support-kpi-next-invoicing-trend"></p>
-                </article>
-              </div>
-            </section>
-
             <section id="support-recommendations-wrapper" hidden>
               <h3 class="helpdesk-support-section-title"><?php e(t('Attention needed')); ?></h3>
               <div id="support-system-recommendations"></div>
diff --git a/modules/helpdesk/web/js/helpdesk-detail.js b/modules/helpdesk/web/js/helpdesk-detail.js
index cefbb4d..d62d65f 100644
--- a/modules/helpdesk/web/js/helpdesk-detail.js
+++ b/modules/helpdesk/web/js/helpdesk-detail.js
@@ -417,70 +417,6 @@ function init(container) {
     return html;
   }
 
-  function renderSupportContractKpis(contracts) {
-    const entries = Array.isArray(contracts) ? contracts : [];
-    const wrapper = document.getElementById('support-contract-kpis-wrapper');
-    if (!wrapper) return;
-
-    if (entries.length === 0) {
-      wrapper.hidden = true;
-      return;
-    }
-
-    const amountFmt = new Intl.NumberFormat(undefined, {
-      style: 'currency',
-      currency: 'EUR',
-      maximumFractionDigits: 0,
-    });
-
-    const activeCount = entries.filter(c => String(c.state || '').toLowerCase() !== 'ended').length;
-    const totalVolume = entries.reduce((sum, c) => sum + Number(c.total_payoff_amount ?? 0), 0);
-    const totalSupportHours = entries.reduce((sum, c) => sum + Number(c.support_hours ?? 0), 0);
-
-    // Find nearest next invoicing
-    const now = Date.now();
-    let nearestInvoicing = null;
-    for (const c of entries) {
-      const raw = String(c.next_invoicing_date || '').trim();
-      if (!raw || raw.startsWith('0001-01-01')) continue;
-      const date = new Date(raw);
-      if (!Number.isNaN(date.getTime()) && date.getTime() > now) {
-        if (!nearestInvoicing || date < nearestInvoicing) nearestInvoicing = date;
-      }
-    }
-
-    setText('support-kpi-active-contracts', activeCount);
-    const totalContracts = entries.length;
-    if (totalContracts > activeCount) {
-      setHtml('support-kpi-active-contracts-trend',
-        `<span class="helpdesk-kpi-trend-neutral">${esc(t('of {total} total').replace('{total}', totalContracts))}</span>`);
-    }
-
-    setText('support-kpi-monthly-volume', amountFmt.format(totalVolume));
-
-    if (totalSupportHours > 0) {
-      setText('support-kpi-support-hours',
-        (Number.isInteger(totalSupportHours) ? totalSupportHours : totalSupportHours.toFixed(1)) + 'h');
-    } else {
-      setText('support-kpi-support-hours', '—');
-    }
-
-    if (nearestInvoicing) {
-      setText('support-kpi-next-invoicing', nearestInvoicing.toLocaleDateString());
-      const daysUntil = Math.ceil((nearestInvoicing.getTime() - now) / 86400000);
-      if (daysUntil >= 0) {
-        const cls = daysUntil <= 7 ? 'helpdesk-kpi-trend-negative'
-          : daysUntil <= 30 ? 'helpdesk-kpi-trend-neutral'
-          : 'helpdesk-kpi-trend-positive';
-        setHtml('support-kpi-next-invoicing-trend',
-          `<span class="${cls}">${esc(t('in {days} days').replace('{days}', daysUntil))}</span>`);
-      }
-    } else {
-      setText('support-kpi-next-invoicing', '—');
-    }
-
-    wrapper.hidden = false;
-  }
 
   function contractTypeLabel(productType) {
     return String(productType || '').trim() || '—';
@@ -925,9 +861,6 @@ function init(container) {
       ageHintEl.innerHTML = `<span class="helpdesk-kpi-trend-negative">${criticalTickets} ${t('critical')}</span>`;
     }
 
-    // Contract KPIs (second row)
-    const contracts = Array.isArray(result.contracts) ? result.contracts : [];
-    renderSupportContractKpis(contracts);
 
     // Recommendations + escalations merged — only show section when there are entries
     const recommendationsWrapper = document.getElementById('support-recommendations-wrapper');