From c80e3178755c1aa65bc2513b9f68d7190b7f78f5 Mon Sep 17 00:00:00 2001 From: fs Date: Sun, 5 Apr 2026 20:02:05 +0200 Subject: [PATCH] fix(helpdesk): fix contact name resolution when customerNo is empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit getContactsForCustomerWithMeta() returned early when customerNo OR customerName was empty. The communication service calls it with empty customerNo and only customerName — which always hit the early return, preventing any contact lookup. Fix: only return early when BOTH are empty, so the primary Company_Name query path works correctly. Co-Authored-By: Claude Opus 4.6 (1M context) --- modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php b/modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php index 0362d1f..6337716 100644 --- a/modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php +++ b/modules/helpdesk/lib/Module/Helpdesk/Service/BcODataGateway.php @@ -224,7 +224,7 @@ class BcODataGateway { $customerNo = trim($customerNo); $customerName = trim($customerName); - if ($customerNo === '' || $customerName === '') { + if ($customerNo === '' && $customerName === '') { return [ 'contacts' => [], 'meta' => [