fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat: introduce module system and extract address book as first module (MODULAR-MONOLITH-V1-001)

Browse Source 
Add a module kernel (ModuleManifest, ModuleRegistry) that allows modules to
contribute routes, UI slots, search providers, layout context, session
lifecycle, and permissions. Modules are activated via config/modules.php or
APP_ENABLED_MODULES env variable. Conflicts (duplicate routes, permissions,
slot keys) cause a fail-fast with a clear error message.

Extract the address book from hardcoded Core integration points into the
first module (modules/addressbook/). The module provides:
- Aside icon-bar tab + People panel via UI slot system
- Global search resource via AddressBookSearchProvider
- Layout context data via AddressBookLayoutProvider
- Session lifecycle via AddressBookSessionProvider

Core cleanup removes address-book hardcodings from SearchSqlResourceProvider,
SearchUiMetaProvider, SearchItemMapperProvider, appBuildLayoutNavContext(),
and the aside templates. Permissions (ADDRESS_BOOK_VIEW) and business logic
(AddressBookService) remain in Core as they gate general user visibility.

Includes 38 new tests (894 total), PHPStan level 5 clean, and architecture
tests verifying zero hardcoded address-book references in search/templates.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-18 15:43:25 +01:00
parent d9805c45d3
commit c364e2b46d
33 changed files with 2639 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
lib/Service/Search/SearchDataService.php
View File

@@ -27,6 +27,26 @@ class SearchDataService
$tenantScopeFilters = SearchConfig::tenantScopeFilters();
$resources = SearchConfig::resources($query, $locale);
// Merge module-contributed search resources into the pipeline
$like = \MintyPHP\Support\Search\SearchQueryNormalizer::normalizeLikeQuery($query);
foreach (SearchConfig::moduleResources() as $key => $moduleDef) {
$countSql = $moduleDef['count_sql'];
$previewSql = $moduleDef['preview_sql'];
$resultSql = $moduleDef['result_sql'];
$resources[] = [
'key' => $key,
'label' => $moduleDef['label'],
'permission' => $moduleDef['permission'],
'countSql' => $countSql,
'countParams' => array_fill(0, substr_count($countSql, '?'), $like),
'previewSql' => $previewSql,
'previewParams' => array_fill(0, max(0, substr_count($previewSql, '?') - 1), $like),
'resultSql' => $resultSql,
'resultParams' => array_fill(0, substr_count($resultSql, '?'), $like),
];
}
$items = [];
foreach ($resources as $resource) {
@@ -129,6 +149,26 @@ class SearchDataService
$tenantScopeFilters = SearchConfig::tenantScopeFilters();
$resources = SearchConfig::resources($query, $locale);
// Merge module-contributed search resources
$like = \MintyPHP\Support\Search\SearchQueryNormalizer::normalizeLikeQuery($query);
foreach (SearchConfig::moduleResources() as $key => $moduleDef) {
$countSql = $moduleDef['count_sql'];
$previewSql = $moduleDef['preview_sql'];
$resultSql = $moduleDef['result_sql'];
$resources[] = [
'key' => $key,
'label' => $moduleDef['label'],
'permission' => $moduleDef['permission'],
'countSql' => $countSql,
'countParams' => array_fill(0, substr_count($countSql, '?'), $like),
'previewSql' => $previewSql,
'previewParams' => array_fill(0, max(0, substr_count($previewSql, '?') - 1), $like),
'resultSql' => $resultSql,
'resultParams' => array_fill(0, substr_count($resultSql, '?'), $like),
];
}
$results = [];
foreach ($resources as $resource) {