fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Strengthen settings gateway tests

Browse Source
This commit is contained in:
Felix Schneider
2026-03-19 20:32:34 +01:00
parent bc59ace240
commit b873efc973
4 changed files with 157 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
tests/Service/Settings/SettingsUserLifecycleGatewayTest.php
View File

@@ -33,6 +33,18 @@ class SettingsUserLifecycleGatewayTest extends TestCase
$this->assertTrue($gateway->setUserInactivityDeactivateDays(0));
}
public function testSetUserInactivityDeactivateDaysReturnsFalseWhenDeleteResetFails(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->once())
->method('set')
->with('user_inactivity_delete_days', '0', 'setting.user_inactivity_delete_days')
->willReturn(false);
$gateway = new SettingsUserLifecycleGateway(new SettingsMetadataGateway($settings));
$this->assertFalse($gateway->setUserInactivityDeactivateDays(0));
}
public function testGetUserInactivityDeleteDaysReturnsZeroWhenDeactivateDisabled(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
@@ -49,4 +61,30 @@ class SettingsUserLifecycleGatewayTest extends TestCase
$gateway = new SettingsUserLifecycleGateway(new SettingsMetadataGateway($settings));
$this->assertSame(0, $gateway->getUserInactivityDeleteDays());
}
public function testGetUserInactivityDeleteDaysFallsBackWhenStoredValueIsInvalid(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturnCallback(static function (string $key): ?string {
if ($key === 'user_inactivity_deactivate_days') {
return '180';
}
if ($key === 'user_inactivity_delete_days') {
return '99999';
}
return null;
});
$gateway = new SettingsUserLifecycleGateway(new SettingsMetadataGateway($settings));
$this->assertSame(365, $gateway->getUserInactivityDeleteDays());
}
public function testSetUserInactivityDeleteDaysRejectsOutOfRangeValue(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->never())->method('set');
$gateway = new SettingsUserLifecycleGateway(new SettingsMetadataGateway($settings));
$this->assertFalse($gateway->setUserInactivityDeleteDays(3651));
}
}