From a721ec00430e8ba8077cf73d40dbdbee5091b7d0 Mon Sep 17 00:00:00 2001
From: fs <fs@breadcrumb-solutions.de>
Date: Wed, 25 Mar 2026 07:48:13 +0100
Subject: [PATCH] refactor(admin): split SSO tab into separate Microsoft SSO
 and LDAP tabs

Replace the single "SSO" tab in tenant edit with two dedicated tabs:
"Microsoft SSO" and "LDAP". Each provider now has its own tab panel
with focused status tiles and config cards, reducing scroll and
cognitive load for admins configuring a single provider.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 i18n/default_de.json            | 3 ++-
 i18n/default_en.json            | 3 ++-
 pages/admin/tenants/_form.phtml | 8 +++++---
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/i18n/default_de.json b/i18n/default_de.json
index 1e5bc8c..391624d 100644
--- a/i18n/default_de.json
+++ b/i18n/default_de.json
@@ -1413,5 +1413,6 @@
   "Use %s as placeholder for the username. Examples: (&(objectClass=user)(sAMAccountName=%s)) for AD, (&(objectClass=inetOrgPerson)(uid=%s)) for OpenLDAP": "Verwenden Sie %s als Platzhalter für den Benutzernamen. Beispiele: (&(objectClass=user)(sAMAccountName=%s)) für AD, (&(objectClass=inetOrgPerson)(uid=%s)) für OpenLDAP",
   "Username or password not valid": "Benutzername oder Passwort ungültig",
   "Write-only. Leave empty to keep current value.": "Nur Schreibzugriff. Leer lassen, um den aktuellen Wert beizubehalten.",
-  "Your account is deactivated.": "Ihr Konto ist deaktiviert."
+  "Your account is deactivated.": "Ihr Konto ist deaktiviert.",
+  "LDAP": "LDAP"
 }
diff --git a/i18n/default_en.json b/i18n/default_en.json
index 6dd9f98..732ddd5 100644
--- a/i18n/default_en.json
+++ b/i18n/default_en.json
@@ -1413,5 +1413,6 @@
   "Use %s as placeholder for the username. Examples: (&(objectClass=user)(sAMAccountName=%s)) for AD, (&(objectClass=inetOrgPerson)(uid=%s)) for OpenLDAP": "Use %s as placeholder for the username. Examples: (&(objectClass=user)(sAMAccountName=%s)) for AD, (&(objectClass=inetOrgPerson)(uid=%s)) for OpenLDAP",
   "Username or password not valid": "Username or password not valid",
   "Write-only. Leave empty to keep current value.": "Write-only. Leave empty to keep current value.",
-  "Your account is deactivated.": "Your account is deactivated."
+  "Your account is deactivated.": "Your account is deactivated.",
+  "LDAP": "LDAP"
 }
diff --git a/pages/admin/tenants/_form.phtml b/pages/admin/tenants/_form.phtml
index 4b53be7..ec7df2b 100644
--- a/pages/admin/tenants/_form.phtml
+++ b/pages/admin/tenants/_form.phtml
@@ -151,7 +151,8 @@ $openOverrideCard = $detailsOpenAll;
         <button type="button" data-tab="custom_fields"><?php e(t('User custom fields')); ?></button>
       <?php endif; ?>
       <?php if ($showSsoTab): ?>
-        <button type="button" data-tab="sso"><?php e(t('SSO')); ?></button>
+        <button type="button" data-tab="sso"><?php e(t('Microsoft SSO')); ?></button>
+        <button type="button" data-tab="ldap"><?php e(t('LDAP')); ?></button>
       <?php endif; ?>
       <button type="button" data-tab="visibility"><?php e(t('Visibility')); ?></button>
       <?php if ($showDangerZone && $dangerZoneDeleteFormId !== ''): ?>
@@ -679,6 +680,9 @@ $openOverrideCard = $detailsOpenAll;
           </div>
         </details>
 
+      </div>
+
+      <div data-tab-panel="ldap">
         <?php
         // ── LDAP configuration section ────────────────────────────────
         $ldapUiState = is_array($ldapUiState ?? null) ? $ldapUiState : [];
@@ -712,9 +716,7 @@ $openOverrideCard = $detailsOpenAll;
         $ldapConfigErrorLabel = trim((string) ($ldapUiState['config_error_label'] ?? ''));
         $openLdapSetupCard = $detailsOpenAll || !$ldapEnabled || ($ldapEnabled && !$ldapConfigComplete);
         ?>
-        <hr>
         <div data-tenant-ldap-root>
-        <h4><?php e(t('LDAP Authentication')); ?></h4>
 
         <div class="app-form-info-tiles">
           <?php