fix(helpdesk): drop stale require of removed app-flash partial

Commit 4890a28 folded templates/partials/app-flash.phtml into
app-toast-stack.phtml, which the base layout now mounts itself. 14
helpdesk views still required the deleted partial and crashed every
helpdesk page with a 500 (Failed opening required app-flash.phtml).
Remove the redundant requires; the unified toast stack continues to
render flash messages via the layout.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-29 07:59:51 +02:00
parent 6146b0bd00
commit a5213977ca
14 changed files with 0 additions and 24 deletions

View File

@@ -60,8 +60,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php if ($hasError): ?> <?php if ($hasError): ?>
<div class="notice" data-variant="error" role="alert"> <div class="notice" data-variant="error" role="alert">
<p><?php e(t('Could not connect to Business Central.')); ?></p> <p><?php e(t('Could not connect to Business Central.')); ?></p>

View File

@@ -61,8 +61,6 @@ $stateVariant = $stateVariantMap[$domainState] ?? 'neutral';
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php if ($hasError): ?> <?php if ($hasError): ?>
<div class="notice" data-variant="error" role="alert"> <div class="notice" data-variant="error" role="alert">
<p><?php e(t('Could not connect to Business Central.')); ?></p> <p><?php e(t('Could not connect to Business Central.')); ?></p>

View File

@@ -9,8 +9,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
$filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : []; $filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : [];
$isConfigured = $isConfigured ?? false; $isConfigured = $isConfigured ?? false;
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php if (!$isConfigured): ?> <?php if (!$isConfigured): ?>
<div class="notice" data-variant="warning" role="alert"> <div class="notice" data-variant="warning" role="alert">
<p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p> <p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p>

View File

@@ -16,8 +16,6 @@ $steps = [
['label' => t('Protocol'), 'number' => 2], ['label' => t('Protocol'), 'number' => 2],
]; ];
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<div class="app-wizard-content"> <div class="app-wizard-content">
<div class="app-wizard-header"> <div class="app-wizard-header">
<a href="<?php e(lurl($closeTarget)); ?>" class="app-wizard-back" data-tooltip="<?php e(t('Back to list')); ?>"> <a href="<?php e(lurl($closeTarget)); ?>" class="app-wizard-back" data-tooltip="<?php e(t('Back to list')); ?>">

View File

@@ -26,8 +26,6 @@ $editBasePath = $editBasePath ?? ('helpdesk/handovers/edit/' . ($handover['id']
?> ?>
<div class="app-details-container"> <div class="app-details-container">
<section> <section>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php <?php
$titlebar = [ $titlebar = [
'title' => $titleText ?? t('Handover'), 'title' => $titleText ?? t('Handover'),

View File

@@ -10,8 +10,6 @@ $filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : [];
$canCreate = $canCreate ?? false; $canCreate = $canCreate ?? false;
$canManage = $canManage ?? false; $canManage = $canManage ?? false;
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php <?php
$listTitle = t('Handovers'); $listTitle = t('Handovers');
ob_start(); ob_start();

View File

@@ -9,8 +9,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
$filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : []; $filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : [];
$isConfigured = $isConfigured ?? false; $isConfigured = $isConfigured ?? false;
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php if (!$isConfigured): ?> <?php if (!$isConfigured): ?>
<div class="notice" data-variant="warning" role="alert"> <div class="notice" data-variant="warning" role="alert">
<p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p> <p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p>

View File

@@ -55,7 +55,6 @@ $periodLabels = [
], ],
]; ];
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
require templatePath('partials/app-flash.phtml');
?> ?>
<div class="helpdesk-risk-radar-dashboard"> <div class="helpdesk-risk-radar-dashboard">

View File

@@ -91,7 +91,6 @@ $tenantIsOAuth2 = $tenantAuthMode === HelpdeskSettingsGateway::AUTH_MODE_OAUTH2;
], ],
]; ];
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
require templatePath('partials/app-flash.phtml');
?> ?>
<?php if ($configErrors !== []): ?> <?php if ($configErrors !== []): ?>

View File

@@ -11,8 +11,6 @@ $active = (int) ($values['active'] ?? 1);
?> ?>
<div class="app-details-container"> <div class="app-details-container">
<section> <section>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php <?php
$titlebar = [ $titlebar = [
'title' => $titleText ?? t('Edit software product'), 'title' => $titleText ?? t('Edit software product'),

View File

@@ -9,8 +9,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
$filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : []; $filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : [];
$isConfigured = $isConfigured ?? false; $isConfigured = $isConfigured ?? false;
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php if (!$isConfigured): ?> <?php if (!$isConfigured): ?>
<div class="notice" data-variant="warning" role="alert"> <div class="notice" data-variant="warning" role="alert">
<p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p> <p><?php e(t('BC connection is not configured. Please configure the connection in the settings.')); ?></p>

View File

@@ -51,7 +51,6 @@ $periodLabels = [
], ],
]; ];
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
require templatePath('partials/app-flash.phtml');
?> ?>
<div class="helpdesk-team-dashboard"> <div class="helpdesk-team-dashboard">

View File

@@ -34,5 +34,4 @@ $titlebar = [
] : [], ] : [],
]; ];
require templatePath('partials/app-details-titlebar.phtml'); require templatePath('partials/app-details-titlebar.phtml');
require templatePath('partials/app-flash.phtml');
require __DIR__ . '/../../templates/helpdesk-ticket-detail.phtml'; require __DIR__ . '/../../templates/helpdesk-ticket-detail.phtml';

View File

@@ -9,8 +9,6 @@ $searchConfig = is_array($searchConfig ?? null) ? $searchConfig : null;
$filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : []; $filterChipMeta = is_array($filterChipMeta ?? null) ? $filterChipMeta : [];
$canManage = $canManage ?? false; $canManage = $canManage ?? false;
?> ?>
<?php require templatePath('partials/app-flash.phtml'); ?>
<?php <?php
$listTitle = t('Updates'); $listTitle = t('Updates');
ob_start(); ob_start();