fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

feat(helpdesk): align module with core list/drawer standards

Browse Source 
- add helpdesk module pages, services, settings and tests

- standardize debtor list on drawer/grid contracts and robust filter drawer behavior

- add helpdesk aside panel navigation and settings visibility provider

- switch primary list slug to helpdesk/debitor and remove helpdesk/search compatibility

- include required core contract updates for list contracts and detail/drawer integration
This commit is contained in:
Felix Schneider
2026-04-02 17:48:27 +02:00
parent 5d07236758
commit a0d7670dd7
55 changed files with 5977 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

195
modules/helpdesk/tests/Module/Helpdesk/Service/HelpdeskSettingsGatewayTest.php Normal file
View File

@@ -0,0 +1,195 @@
<?php
namespace MintyPHP\Tests\Module\Helpdesk\Service;
use MintyPHP\Module\Helpdesk\Service\HelpdeskSettingsGateway;
use MintyPHP\Repository\Settings\SettingRepositoryInterface;
use MintyPHP\Service\Settings\SettingsCryptoGatewayInterface;
use MintyPHP\Service\Settings\SettingsMetadataGateway;
use PHPUnit\Framework\TestCase;
class HelpdeskSettingsGatewayTest extends TestCase
{
private function createGateway(?SettingRepositoryInterface $settings = null, ?SettingsCryptoGatewayInterface $crypto = null): HelpdeskSettingsGateway
{
$settings = $settings ?? $this->createMock(SettingRepositoryInterface::class);
$crypto = $crypto ?? $this->createMock(SettingsCryptoGatewayInterface::class);
return new HelpdeskSettingsGateway(new SettingsMetadataGateway($settings), $crypto);
}
public function testGetAuthModeDefaultsToBasic(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturn(null);
$gateway = $this->createGateway($settings);
$this->assertSame('basic', $gateway->getAuthMode());
}
public function testGetAuthModeReturnsOAuth2WhenSet(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturn('oauth2');
$gateway = $this->createGateway($settings);
$this->assertSame('oauth2', $gateway->getAuthMode());
}
public function testSetAuthModeRejectsInvalidMode(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->never())->method('set');
$gateway = $this->createGateway($settings);
$this->assertFalse($gateway->setAuthMode('invalid'));
}
public function testSetODataBaseUrlRejectsHttp(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->never())->method('set');
$gateway = $this->createGateway($settings);
$this->assertFalse($gateway->setODataBaseUrl('http://insecure.example.com'));
}
public function testSetODataBaseUrlAcceptsHttps(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->once())
->method('set')
->with(HelpdeskSettingsGateway::KEY_ODATA_BASE_URL, 'https://bc.example.com/OData', 'helpdesk.bc_odata_base_url')
->willReturn(true);
$gateway = $this->createGateway($settings);
$this->assertTrue($gateway->setODataBaseUrl('https://bc.example.com/OData'));
}
public function testGetBasicPasswordReturnsNullWhenDecryptFails(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturn('encrypted-value');
$crypto = $this->createMock(SettingsCryptoGatewayInterface::class);
$crypto->method('decryptString')->willThrowException(new \RuntimeException('bad key'));
$gateway = $this->createGateway($settings, $crypto);
$this->assertNull($gateway->getBasicPassword());
}
public function testSetBasicPasswordEncryptsAndPersists(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->once())
->method('set')
->with(HelpdeskSettingsGateway::KEY_BASIC_PASSWORD_ENC, 'enc-pw', 'helpdesk.bc_basic_password_enc')
->willReturn(true);
$crypto = $this->createMock(SettingsCryptoGatewayInterface::class);
$crypto->expects($this->once())
->method('encryptString')
->with('my-password')
->willReturn('enc-pw');
$gateway = $this->createGateway($settings, $crypto);
$this->assertTrue($gateway->setBasicPassword('my-password'));
}
public function testSetBasicPasswordClearsWhenEmpty(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->once())
->method('set')
->with(HelpdeskSettingsGateway::KEY_BASIC_PASSWORD_ENC, null, 'helpdesk.bc_basic_password_enc')
->willReturn(true);
$crypto = $this->createMock(SettingsCryptoGatewayInterface::class);
$crypto->expects($this->never())->method('encryptString');
$gateway = $this->createGateway($settings, $crypto);
$this->assertTrue($gateway->setBasicPassword(''));
}
public function testSetBasicPasswordReturnsFalseOnEncryptionFailure(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->never())->method('set');
$crypto = $this->createMock(SettingsCryptoGatewayInterface::class);
$crypto->method('encryptString')->willThrowException(new \RuntimeException('encryption failed'));
$gateway = $this->createGateway($settings, $crypto);
$this->assertFalse($gateway->setBasicPassword('my-password'));
}
public function testBuildEntityUrlConstructsCorrectUrl(): void
{
$callMap = [
[HelpdeskSettingsGateway::KEY_ODATA_BASE_URL, 'https://bc.example.com/ODataV4'],
[HelpdeskSettingsGateway::KEY_COMPANY_NAME, 'Test Company'],
];
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturnCallback(static function (string $key) use ($callMap): ?string {
foreach ($callMap as [$k, $v]) {
if ($k === $key) {
return $v;
}
}
return null;
});
$gateway = $this->createGateway($settings);
$url = $gateway->buildEntityUrl('Integration_Customer_Card');
$this->assertSame("https://bc.example.com/ODataV4/Company('Test%20Company')/Integration_Customer_Card", $url);
}
public function testValidateConfigurationReportsMissingBasicCredentials(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturn(null);
$gateway = $this->createGateway($settings);
$missing = $gateway->validateConfiguration();
$this->assertNotEmpty($missing);
$this->assertContains('BC Basic Auth User', $missing);
$this->assertContains('BC Basic Auth Password', $missing);
}
public function testIsConfiguredReturnsTrueWhenBasicCredentialsPresent(): void
{
$callMap = [
[HelpdeskSettingsGateway::KEY_AUTH_MODE, 'basic'],
[HelpdeskSettingsGateway::KEY_BASIC_USER, 'testuser'],
[HelpdeskSettingsGateway::KEY_BASIC_PASSWORD_ENC, 'encrypted'],
];
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->method('getValue')->willReturnCallback(static function (string $key) use ($callMap): ?string {
foreach ($callMap as [$k, $v]) {
if ($k === $key) {
return $v;
}
}
return null;
});
$crypto = $this->createMock(SettingsCryptoGatewayInterface::class);
$crypto->method('decryptString')->willReturn('decrypted-password');
$gateway = $this->createGateway($settings, $crypto);
$this->assertTrue($gateway->isConfigured());
}
public function testSetOAuthTokenEndpointRejectsHttp(): void
{
$settings = $this->createMock(SettingRepositoryInterface::class);
$settings->expects($this->never())->method('set');
$gateway = $this->createGateway($settings);
$this->assertFalse($gateway->setOAuthTokenEndpoint('http://login.microsoftonline.com/token'));
}
}