From 97dbc7f57bbc1e651f1e4095eca432435d6bd4ef Mon Sep 17 00:00:00 2001 From: fs Date: Mon, 6 Apr 2026 00:55:41 +0200 Subject: [PATCH] fix(helpdesk): reset card margin-bottom and tighten risk level thresholds - margin-bottom: 0 on cards to override article shell default - Level thresholds stricter: high >= 55 (was 70), medium >= 25 (was 40) so fewer customers appear as 'low risk' and issues surface earlier Co-Authored-By: Claude Opus 4.6 (1M context) --- .../helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php | 4 ++-- .../tests/Module/Helpdesk/Service/RiskRadarServiceTest.php | 4 ++-- modules/helpdesk/web/css/helpdesk.css | 1 + 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/modules/helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php b/modules/helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php index 319d4ac..9e48203 100644 --- a/modules/helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php +++ b/modules/helpdesk/lib/Module/Helpdesk/Service/RiskRadarService.php @@ -15,8 +15,8 @@ final class RiskRadarService private const W_INACTIVITY = 10; // --- Level thresholds --- - private const LEVEL_HIGH = 70; - private const LEVEL_MEDIUM = 40; + private const LEVEL_HIGH = 55; + private const LEVEL_MEDIUM = 25; private const CLOSED_STATES = ['Erledigt', 'Resolved', 'Closed', 'Geschlossen']; diff --git a/modules/helpdesk/tests/Module/Helpdesk/Service/RiskRadarServiceTest.php b/modules/helpdesk/tests/Module/Helpdesk/Service/RiskRadarServiceTest.php index daaac5c..763e627 100644 --- a/modules/helpdesk/tests/Module/Helpdesk/Service/RiskRadarServiceTest.php +++ b/modules/helpdesk/tests/Module/Helpdesk/Service/RiskRadarServiceTest.php @@ -86,7 +86,7 @@ class RiskRadarServiceTest extends TestCase $result = RiskRadarService::buildRiskRadar($tickets, [], 90); $this->assertSame('high', $result['customers'][0]['risk_level']); - $this->assertGreaterThanOrEqual(70, $result['customers'][0]['risk_score']); + $this->assertGreaterThanOrEqual(55, $result['customers'][0]['risk_score']); } public function testLowRiskLevel(): void @@ -100,7 +100,7 @@ class RiskRadarServiceTest extends TestCase $result = RiskRadarService::buildRiskRadar($tickets, [], 90); $this->assertSame('low', $result['customers'][0]['risk_level']); - $this->assertLessThan(40, $result['customers'][0]['risk_score']); + $this->assertLessThan(25, $result['customers'][0]['risk_score']); } public function testSlaOverdueDetection(): void diff --git a/modules/helpdesk/web/css/helpdesk.css b/modules/helpdesk/web/css/helpdesk.css index c2218ab..00325e3 100644 --- a/modules/helpdesk/web/css/helpdesk.css +++ b/modules/helpdesk/web/css/helpdesk.css @@ -545,6 +545,7 @@ border: 1px solid var(--app-muted-border-color); border-radius: var(--app-radius, 0.375rem); padding: calc(var(--app-spacing) * 0.65) calc(var(--app-spacing) * 0.75); + margin-bottom: 0; transition: border-color 0.15s ease, box-shadow 0.15s ease; cursor: pointer; }