refactor: remove 13 dead code artifacts across core/
Dead methods (9): - Command::bootstrapModuleApp() — unused by all subclasses - SearchConfig::providerCoverageGaps() — diagnostic method, never called - RequestInput::queryArray() — no callers - LocaleResolver::getAvailableLocales() / getDefaultLocale() — unused getters - EmailVerificationService::getExpiryMinutes() — constant wrapper, never called - AuthService::loginAndRedirect() — convenience wrapper, never called - DepartmentService::listForUserAssignments() — no callers - UserTenantContextService::getAvailableDepartmentsByTenant() — no callers Dead functions (3): - navActivePublicPages(), appNormalizeStringList(), appNormalizePositiveIntList() Dead constant (1): - PermissionService::API_DOCS_VIEW — duplicated via other paths Orphaned file (1): - bin/cli-bootstrap.php — never included anywhere Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -79,28 +79,7 @@ class DepartmentService
|
||||
return $this->departmentRepository->listByIds($departmentIds);
|
||||
}
|
||||
|
||||
// Merges the tenant-scoped list with any already-selected departments outside the filter —
|
||||
// ensures a user keeps visibility of departments they're already assigned to.
|
||||
public function listForUserAssignments(array $tenantIds, array $selectedDepartmentIds): array
|
||||
{
|
||||
$departments = $tenantIds ? $this->listByTenantIds($tenantIds) : $this->list();
|
||||
$extraDepartments = $selectedDepartmentIds ? $this->listByIds($selectedDepartmentIds) : [];
|
||||
if (!$extraDepartments) {
|
||||
return $departments;
|
||||
}
|
||||
$departmentMap = [];
|
||||
foreach ($departments as $department) {
|
||||
if (isset($department['id'])) {
|
||||
$departmentMap[(int) $department['id']] = $department;
|
||||
}
|
||||
}
|
||||
foreach ($extraDepartments as $department) {
|
||||
if (isset($department['id'])) {
|
||||
$departmentMap[(int) $department['id']] = $department;
|
||||
}
|
||||
}
|
||||
return array_values($departmentMap);
|
||||
}
|
||||
|
||||
|
||||
public function findByUuid(string $uuid): ?array
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user