major update
This commit is contained in:
@@ -9,6 +9,8 @@ use PHPUnit\Framework\TestCase;
|
||||
|
||||
class RoleAuthorizationPolicyTest extends TestCase
|
||||
{
|
||||
use AuthorizationPolicyTestSupport;
|
||||
|
||||
public function testAdminViewRequiresRolesViewPermission(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
@@ -22,22 +24,14 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 7,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertSame('forbidden', $decision->error());
|
||||
$this->assertForbiddenDecision($decision);
|
||||
}
|
||||
|
||||
public function testAdminViewIncludesCreateCapability(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static function (int $userId, string $permission): bool {
|
||||
if ($userId !== 7) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return in_array($permission, [PermissionService::ROLES_VIEW, PermissionService::ROLES_CREATE], true);
|
||||
});
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
7 => [PermissionService::ROLES_VIEW, PermissionService::ROLES_CREATE],
|
||||
]);
|
||||
|
||||
$policy = new RoleAuthorizationPolicy($permissionGateway);
|
||||
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_VIEW, [
|
||||
@@ -61,8 +55,7 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 11,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
||||
}
|
||||
|
||||
public function testEditContextRequiresTargetRoleId(): void
|
||||
@@ -76,24 +69,14 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
'target_role_id' => 0,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
||||
}
|
||||
|
||||
public function testEditContextReturnsCapabilities(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static function (int $userId, string $permission): bool {
|
||||
if ($userId !== 5) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return in_array($permission, [
|
||||
PermissionService::ROLES_VIEW,
|
||||
PermissionService::ROLES_UPDATE,
|
||||
], true);
|
||||
});
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
5 => [PermissionService::ROLES_VIEW, PermissionService::ROLES_UPDATE],
|
||||
]);
|
||||
|
||||
$policy = new RoleAuthorizationPolicy($permissionGateway);
|
||||
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_EDIT_CONTEXT, [
|
||||
@@ -109,15 +92,9 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
|
||||
public function testEditSubmitRequiresRolesUpdatePermission(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static function (int $userId, string $permission): bool {
|
||||
if ($userId !== 5) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return $permission === PermissionService::ROLES_VIEW;
|
||||
});
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
5 => [PermissionService::ROLES_VIEW],
|
||||
]);
|
||||
|
||||
$policy = new RoleAuthorizationPolicy($permissionGateway);
|
||||
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_EDIT_SUBMIT, [
|
||||
@@ -125,9 +102,7 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
'target_role_id' => 22,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertSame('forbidden', $decision->error());
|
||||
$this->assertForbiddenDecision($decision);
|
||||
}
|
||||
|
||||
public function testDeleteRequiresRolesDeletePermission(): void
|
||||
@@ -143,7 +118,6 @@ class RoleAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 6,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user