major update
This commit is contained in:
@@ -10,6 +10,8 @@ use PHPUnit\Framework\TestCase;
|
||||
|
||||
class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
{
|
||||
use AuthorizationPolicyTestSupport;
|
||||
|
||||
public function testViewRequiresDepartmentsViewPermission(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
@@ -27,22 +29,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 5,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertSame('forbidden', $decision->error());
|
||||
$this->assertForbiddenDecision($decision);
|
||||
}
|
||||
|
||||
public function testViewReturnsCreateCapabilityAndTenantScopeData(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static function (int $userId, string $permission): bool {
|
||||
if ($userId !== 5) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return in_array($permission, [PermissionService::DEPARTMENTS_VIEW, PermissionService::DEPARTMENTS_CREATE], true);
|
||||
});
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
5 => [PermissionService::DEPARTMENTS_VIEW, PermissionService::DEPARTMENTS_CREATE],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -82,15 +76,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 7,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
||||
}
|
||||
|
||||
public function testCreateDeniedInStrictScopeWithoutTenantAssignments(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static fn (int $userId, string $permission): bool => $userId === 7 && $permission === PermissionService::DEPARTMENTS_CREATE);
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
7 => [PermissionService::DEPARTMENTS_CREATE],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -106,16 +99,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'actor_user_id' => 7,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertSame('permission_denied', $decision->error());
|
||||
$this->assertDeniedDecision($decision, 403, 'permission_denied');
|
||||
}
|
||||
|
||||
public function testCreateReturnsScopeCapabilitiesWhenAllowed(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static fn (int $userId, string $permission): bool => $userId === 7 && $permission === PermissionService::DEPARTMENTS_CREATE);
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
7 => [PermissionService::DEPARTMENTS_CREATE],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -149,16 +140,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'target_department_id' => 17,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame(403, $decision->status());
|
||||
$this->assertSame('forbidden', $decision->error());
|
||||
$this->assertForbiddenDecision($decision);
|
||||
}
|
||||
|
||||
public function testEditContextDeniesOutOfScopeDepartment(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static fn (int $userId, string $permission): bool => $userId === 5 && $permission === PermissionService::DEPARTMENTS_VIEW);
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
5 => [PermissionService::DEPARTMENTS_VIEW],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -172,21 +161,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'target_department_id' => 17,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame('permission_denied', $decision->error());
|
||||
$this->assertDeniedDecision($decision, 403, 'permission_denied');
|
||||
}
|
||||
|
||||
public function testEditSubmitRequiresDepartmentsUpdatePermission(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static function (int $userId, string $permission): bool {
|
||||
if ($userId !== 5) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return $permission === PermissionService::DEPARTMENTS_VIEW;
|
||||
});
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
5 => [PermissionService::DEPARTMENTS_VIEW],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -204,15 +186,14 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'target_department_id' => 17,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame('forbidden', $decision->error());
|
||||
$this->assertDeniedDecision($decision, 403, 'forbidden');
|
||||
}
|
||||
|
||||
public function testDeleteRequiresPermissionAndScope(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static fn (int $userId, string $permission): bool => $userId === 9 && $permission === PermissionService::DEPARTMENTS_DELETE);
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
9 => [PermissionService::DEPARTMENTS_DELETE],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -231,9 +212,9 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
|
||||
public function testDeleteDeniesOutOfScopeDepartment(): void
|
||||
{
|
||||
$permissionGateway = $this->createMock(PermissionGateway::class);
|
||||
$permissionGateway->method('userHas')
|
||||
->willReturnCallback(static fn (int $userId, string $permission): bool => $userId === 9 && $permission === PermissionService::DEPARTMENTS_DELETE);
|
||||
$permissionGateway = $this->permissionGatewayAllowing([
|
||||
9 => [PermissionService::DEPARTMENTS_DELETE],
|
||||
]);
|
||||
|
||||
$scopeGateway = $this->createMock(DirectoryScopeGateway::class);
|
||||
$scopeGateway->expects($this->once())
|
||||
@@ -247,7 +228,6 @@ class DepartmentAuthorizationPolicyTest extends TestCase
|
||||
'target_department_id' => 44,
|
||||
]);
|
||||
|
||||
$this->assertFalse($decision->isAllowed());
|
||||
$this->assertSame('permission_denied', $decision->error());
|
||||
$this->assertDeniedDecision($decision, 403, 'permission_denied');
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user