major update

2026-03-04 15:56:58 +01:00
parent 16759a2732
commit 8f4dd5840d
478 changed files with 24313 additions and 8201 deletions
--- a/tests/Architecture/CoreStarterkitContractTest.php
+++ b/tests/Architecture/CoreStarterkitContractTest.php
@@ -0,0 +1,90 @@
+<?php
+
+namespace MintyPHP\Tests\Architecture;
+
+use PHPUnit\Framework\TestCase;
+use RecursiveDirectoryIterator;
+use RecursiveIteratorIterator;
+
+class CoreStarterkitContractTest extends TestCase
+{
+    use ProjectFileAssertionSupport;
+
+    public function testPagesDoNotInstantiateServicesRepositoriesOrGatewaysDirectly(): void
+    {
+        $violations = $this->findPatternMatchesInPhpFiles('pages', '/\bnew\s+[\\\\A-Za-z0-9_]+(?:Service|Gateway|Repository)\s*\(/');
+        $this->assertSame([], $violations, "Direct service/repository/gateway instantiation found in pages/:\n" . implode("\n", $violations));
+    }
+
+    public function testPagesDoNotUseDatabaseFacadeDirectly(): void
+    {
+        $violations = $this->findPatternMatchesInPhpFiles('pages', '/\bDB::/');
+        $this->assertSame([], $violations, "Direct DB facade usage found in pages/:\n" . implode("\n", $violations));
+    }
+
+    public function testAdminPagesDoNotUseFactoryCreateChains(): void
+    {
+        $violations = $this->findPatternMatchesInPhpFiles('pages/admin', '/app\([^\n]*Factory::class\)->create/');
+        $this->assertSame([], $violations, "Factory create-chain usage found in pages/admin/:\n" . implode("\n", $violations));
+    }
+
+    public function testAdminPagesDoNotReferenceFactoryClasses(): void
+    {
+        $violations = $this->findPatternMatchesInPhpFiles('pages/admin', '/Factory::class/');
+        $this->assertSame([], $violations, "Factory class usage found in pages/admin/:\n" . implode("\n", $violations));
+    }
+
+    public function testPagesUseRequestInputInsteadOfSuperglobals(): void
+    {
+        $patterns = [
+            '/\$_POST/' => '$_POST',
+            '/\$_GET/' => '$_GET',
+            '/\$_FILES/' => '$_FILES',
+            '/REQUEST_METHOD/' => 'REQUEST_METHOD',
+        ];
+
+        foreach ($patterns as $pattern => $label) {
+            $violations = $this->findPatternMatchesInPhpFiles('pages', $pattern);
+            $this->assertSame([], $violations, "Superglobal {$label} usage found in pages/:\n" . implode("\n", $violations));
+        }
+    }
+
+    public function testApiPagesDoNotReadJsonBodyDirectly(): void
+    {
+        $violations = $this->findPatternMatchesInPhpFiles('pages/api/v1', '/ApiResponse::readJsonBody\s*\(/');
+        $this->assertSame([], $violations, "ApiResponse::readJsonBody usage found in pages/api/v1/:\n" . implode("\n", $violations));
+    }
+
+    /**
+     * @return list<string>
+     */
+    private function findPatternMatchesInPhpFiles(string $relativeDirectory, string $pattern): array
+    {
+        $root = $this->projectRootPath();
+        $basePath = $root . '/' . $relativeDirectory;
+        $this->assertDirectoryExists($basePath, 'Directory not found: ' . $relativeDirectory);
+
+        $iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($basePath));
+        $violations = [];
+
+        /** @var \SplFileInfo $file */
+        foreach ($iterator as $file) {
+            if (!$file->isFile() || $file->getExtension() !== 'php') {
+                continue;
+            }
+
+            $content = file_get_contents($file->getPathname());
+            $this->assertNotFalse($content, 'Could not read file: ' . $file->getPathname());
+
+            if (!preg_match($pattern, $content)) {
+                continue;
+            }
+
+            $relativePath = str_replace($root . '/', '', $file->getPathname());
+            $violations[] = $relativePath;
+        }
+
+        sort($violations);
+        return $violations;
+    }
+}