fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(arch): enforce gateway compliance and remove service-wrapping gateways

Browse Source
This commit is contained in:
Felix Schneider
2026-03-13 11:31:33 +01:00
parent 082fa4c9a5
commit 892da0048d
96 changed files with 1117 additions and 1060 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/Service/Access/SettingsAuthorizationPolicyTest.php
View File

@@ -2,7 +2,6 @@
namespace MintyPHP\Tests\Service\Access;
use MintyPHP\Service\Access\PermissionGateway;
use MintyPHP\Service\Access\PermissionService;
use MintyPHP\Service\Access\SettingsAuthorizationPolicy;
use PHPUnit\Framework\TestCase;
@@ -13,13 +12,13 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testViewRequiresSettingsViewPermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(4, PermissionService::SETTINGS_VIEW)
->willReturn(false);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_VIEW, [
'actor_user_id' => 4,
]);
@@ -29,11 +28,11 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testViewReturnsUpdateCapability(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
4 => [PermissionService::SETTINGS_VIEW, PermissionService::SETTINGS_UPDATE],
]);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_VIEW, [
'actor_user_id' => 4,
]);
@@ -44,13 +43,13 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testUpdateRequiresSettingsUpdatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(8, PermissionService::SETTINGS_UPDATE)
->willReturn(false);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_UPDATE, [
'actor_user_id' => 8,
]);
@@ -60,13 +59,13 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testBrandingUpdateRequiresSettingsUpdatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(8, PermissionService::SETTINGS_UPDATE)
->willReturn(false);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_BRANDING_UPDATE, [
'actor_user_id' => 8,
]);
@@ -76,13 +75,13 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testTokenRevokeRequiresSettingsUpdatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(8, PermissionService::SETTINGS_UPDATE)
->willReturn(false);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_TOKENS_REVOKE, [
'actor_user_id' => 8,
]);
@@ -92,13 +91,13 @@ class SettingsAuthorizationPolicyTest extends TestCase
public function testUserLifecycleRunRequiresSettingsUpdatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(8, PermissionService::SETTINGS_UPDATE)
->willReturn(false);
$policy = new SettingsAuthorizationPolicy($permissionGateway);
$policy = new SettingsAuthorizationPolicy($permissionService);
$decision = $policy->authorize(SettingsAuthorizationPolicy::ABILITY_ADMIN_SETTINGS_USER_LIFECYCLE_RUN, [
'actor_user_id' => 8,
]);