fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(arch): enforce gateway compliance and remove service-wrapping gateways

Browse Source
This commit is contained in:
Felix Schneider
2026-03-13 11:31:33 +01:00
parent 082fa4c9a5
commit 892da0048d
96 changed files with 1117 additions and 1060 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/Service/Access/RoleAuthorizationPolicyTest.php
View File

@@ -2,7 +2,6 @@
namespace MintyPHP\Tests\Service\Access;
use MintyPHP\Service\Access\PermissionGateway;
use MintyPHP\Service\Access\PermissionService;
use MintyPHP\Service\Access\RoleAuthorizationPolicy;
use PHPUnit\Framework\TestCase;
@@ -13,13 +12,13 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testAdminViewRequiresRolesViewPermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(7, PermissionService::ROLES_VIEW)
->willReturn(false);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_VIEW, [
'actor_user_id' => 7,
]);
@@ -29,11 +28,11 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testAdminViewIncludesCreateCapability(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
7 => [PermissionService::ROLES_VIEW, PermissionService::ROLES_CREATE],
]);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_VIEW, [
'actor_user_id' => 7,
]);
@@ -44,13 +43,13 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testAdminCreateRequiresRolesCreatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(11, PermissionService::ROLES_CREATE)
->willReturn(false);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_CREATE, [
'actor_user_id' => 11,
]);
@@ -60,10 +59,10 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testEditContextRequiresTargetRoleId(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->never())->method('userHas');
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->never())->method('userHas');
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_EDIT_CONTEXT, [
'actor_user_id' => 5,
'target_role_id' => 0,
@@ -74,11 +73,11 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testEditContextReturnsCapabilities(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
5 => [PermissionService::ROLES_VIEW, PermissionService::ROLES_UPDATE],
]);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_EDIT_CONTEXT, [
'actor_user_id' => 5,
'target_role_id' => 22,
@@ -92,11 +91,11 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testEditSubmitRequiresRolesUpdatePermission(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
5 => [PermissionService::ROLES_VIEW],
]);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_EDIT_SUBMIT, [
'actor_user_id' => 5,
'target_role_id' => 22,
@@ -107,13 +106,13 @@ class RoleAuthorizationPolicyTest extends TestCase
public function testDeleteRequiresRolesDeletePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(6, PermissionService::ROLES_DELETE)
->willReturn(false);
$policy = new RoleAuthorizationPolicy($permissionGateway);
$policy = new RoleAuthorizationPolicy($permissionService);
$decision = $policy->authorize(RoleAuthorizationPolicy::ABILITY_ADMIN_ROLES_DELETE, [
'actor_user_id' => 6,
]);