fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(arch): enforce gateway compliance and remove service-wrapping gateways

Browse Source
This commit is contained in:
Felix Schneider
2026-03-13 11:31:33 +01:00
parent 082fa4c9a5
commit 892da0048d
96 changed files with 1117 additions and 1060 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/Service/Access/PermissionAuthorizationPolicyTest.php
View File

@@ -3,7 +3,6 @@
namespace MintyPHP\Tests\Service\Access;
use MintyPHP\Service\Access\PermissionAuthorizationPolicy;
use MintyPHP\Service\Access\PermissionGateway;
use MintyPHP\Service\Access\PermissionService;
use PHPUnit\Framework\TestCase;
@@ -13,13 +12,13 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testAdminViewRequiresPermissionsViewPermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(9, PermissionService::PERMISSIONS_VIEW)
->willReturn(false);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_VIEW, [
'actor_user_id' => 9,
]);
@@ -29,11 +28,11 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testAdminViewIncludesCreateCapability(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
9 => [PermissionService::PERMISSIONS_VIEW, PermissionService::PERMISSIONS_CREATE],
]);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_VIEW, [
'actor_user_id' => 9,
]);
@@ -44,13 +43,13 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testAdminCreateRequiresPermissionsCreatePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(3, PermissionService::PERMISSIONS_CREATE)
->willReturn(false);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_CREATE, [
'actor_user_id' => 3,
]);
@@ -60,7 +59,7 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testEditContextReturnsCapabilitiesAndSystemDeleteRestriction(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
5 => [
PermissionService::PERMISSIONS_VIEW,
PermissionService::PERMISSIONS_UPDATE,
@@ -68,7 +67,7 @@ class PermissionAuthorizationPolicyTest extends TestCase
],
]);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_EDIT_CONTEXT, [
'actor_user_id' => 5,
'target_permission_id' => 21,
@@ -83,11 +82,11 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testEditSubmitRequiresPermissionsUpdatePermission(): void
{
$permissionGateway = $this->permissionGatewayAllowing([
$permissionService = $this->permissionGatewayAllowing([
5 => [PermissionService::PERMISSIONS_VIEW],
]);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_EDIT_SUBMIT, [
'actor_user_id' => 5,
'target_permission_id' => 21,
@@ -99,13 +98,13 @@ class PermissionAuthorizationPolicyTest extends TestCase
public function testDeleteRequiresPermissionsDeletePermission(): void
{
$permissionGateway = $this->createMock(PermissionGateway::class);
$permissionGateway->expects($this->once())
$permissionService = $this->createMock(PermissionService::class);
$permissionService->expects($this->once())
->method('userHas')
->with(12, PermissionService::PERMISSIONS_DELETE)
->willReturn(false);
$policy = new PermissionAuthorizationPolicy($permissionGateway);
$policy = new PermissionAuthorizationPolicy($permissionService);
$decision = $policy->authorize(PermissionAuthorizationPolicy::ABILITY_ADMIN_PERMISSIONS_DELETE, [
'actor_user_id' => 12,
]);