Erweiterung Contracts und Guards
This commit is contained in:
@@ -18,6 +18,7 @@ Einheitliche Einstufung und Ablage von Findings fuer Docs-/Skills-Audits.
|
||||
- `P0` und `P1` muessen als eigener Run unter `agent-system/runs/` dokumentiert werden.
|
||||
- Naming fuer diese Runs: `DOCS-SKILLS-AUDIT-00x` (fortlaufend).
|
||||
- `P2` und `P3` werden kompakt im laufenden Audit-Protokoll gesammelt und spaeter gebuendelt umgesetzt.
|
||||
- Repo-weite Alt-Slug-/Link-Scans schliessen `agent-system/runs/**` standardmaessig aus.
|
||||
|
||||
## Mindestinhalt pro grossem Finding-Run (`P0`/`P1`)
|
||||
|
||||
|
||||
@@ -44,6 +44,19 @@
|
||||
"name": "Unused Composer packages",
|
||||
"command": "docker compose exec php vendor/bin/composer-unused",
|
||||
"note": "Run periodically (not per-merge). Flag any newly unused package to the reviewer."
|
||||
},
|
||||
{
|
||||
"id": "QG-008",
|
||||
"type": "fast",
|
||||
"name": "Docs link integrity",
|
||||
"command": "bin/docs-link-check.sh",
|
||||
"note": "Default scanner excludes agent-system/runs/** to avoid historical artifact false positives."
|
||||
},
|
||||
{
|
||||
"id": "QG-009",
|
||||
"type": "fast",
|
||||
"name": "Codex skills sync",
|
||||
"command": "bin/codex-skills-sync.sh --check"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
"required": ["task_id", "verdict", "checked_guard_ids", "checked_quality_gate_ids", "findings"],
|
||||
"properties": {
|
||||
"task_id": { "type": "string", "minLength": 1 },
|
||||
"audit_policy_ref": { "type": "string" },
|
||||
"verdict": { "type": "string", "enum": ["pass", "fail"] },
|
||||
"checked_guard_ids": {
|
||||
"type": "array",
|
||||
@@ -30,17 +31,58 @@
|
||||
"properties": {
|
||||
"id": { "type": "string", "minLength": 1 },
|
||||
"severity": { "type": "string", "enum": ["low", "medium", "high", "critical"] },
|
||||
"priority": { "type": "string", "enum": ["P0", "P1", "P2", "P3"] },
|
||||
"rule_ref": {
|
||||
"type": "string",
|
||||
"pattern": "^(GR-[A-Z]+-[0-9]{3}|QG-[0-9]{3})$"
|
||||
},
|
||||
"summary": { "type": "string", "minLength": 1 },
|
||||
"file": { "type": "string", "minLength": 1 },
|
||||
"fix_required": { "type": "string" }
|
||||
"fix_required": { "type": "string" },
|
||||
"run_artifact_id": {
|
||||
"type": "string",
|
||||
"pattern": "^DOCS-SKILLS-AUDIT-[0-9]{3}$"
|
||||
}
|
||||
},
|
||||
"additionalProperties": false
|
||||
}
|
||||
}
|
||||
},
|
||||
"allOf": [
|
||||
{
|
||||
"if": {
|
||||
"properties": {
|
||||
"task_id": { "pattern": "^DOCS-SKILLS-AUDIT-[0-9]{3}$" }
|
||||
},
|
||||
"required": ["task_id"]
|
||||
},
|
||||
"then": {
|
||||
"required": ["audit_policy_ref"],
|
||||
"properties": {
|
||||
"audit_policy_ref": { "const": "agent-system/checks/docs-skills-audit-policy.md" },
|
||||
"findings": {
|
||||
"items": {
|
||||
"allOf": [
|
||||
{
|
||||
"required": ["priority"]
|
||||
},
|
||||
{
|
||||
"if": {
|
||||
"properties": {
|
||||
"priority": { "enum": ["P0", "P1"] }
|
||||
},
|
||||
"required": ["priority"]
|
||||
},
|
||||
"then": {
|
||||
"required": ["run_artifact_id"]
|
||||
}
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
],
|
||||
"additionalProperties": false
|
||||
}
|
||||
|
||||
@@ -23,3 +23,4 @@ Rules:
|
||||
- report quality gate results by gate ID
|
||||
- list each changed file with a short reason
|
||||
- if blocked, set status to `blocked` and list exact blockers
|
||||
- for docs/skills audits, run and report `QG-008` and `QG-009`
|
||||
|
||||
@@ -20,6 +20,7 @@ Rules:
|
||||
- select required quality gate IDs from quality gates list
|
||||
- include at least one risk with mitigation
|
||||
- keep implementation steps actionable and ordered
|
||||
- for docs/skills audits, use task IDs `DOCS-SKILLS-AUDIT-xxx` and include `QG-008` + `QG-009` in required quality gates
|
||||
|
||||
UI task rules (apply when the task touches templates, pages/*.phtml, or web/js|css):
|
||||
- populate `ux_notes.affected_patterns`: list every existing UI pattern or partial being touched (e.g. "app-details-titlebar", "initStandardListPage")
|
||||
|
||||
@@ -10,6 +10,7 @@ Required references:
|
||||
- `agent-system/checks/guard-checklist.md`
|
||||
- `agent-system/checks/guard-catalog.json`
|
||||
- `agent-system/checks/quality-gates.json`
|
||||
- `agent-system/checks/docs-skills-audit-policy.md` (for docs/skills audit tasks)
|
||||
|
||||
Output:
|
||||
- valid JSON by `agent-system/contracts/reviewer-guards.schema.json`
|
||||
@@ -18,3 +19,7 @@ Rules:
|
||||
- findings must reference a concrete guard or gate ID
|
||||
- findings must include file path
|
||||
- use `fail` only when changes are required before finalize
|
||||
- if `task_id` matches `DOCS-SKILLS-AUDIT-xxx`:
|
||||
- set `audit_policy_ref` to `agent-system/checks/docs-skills-audit-policy.md`
|
||||
- classify every finding with `priority` in `P0|P1|P2|P3`
|
||||
- for `P0` and `P1`, set `run_artifact_id` with the same pattern (`DOCS-SKILLS-AUDIT-xxx`)
|
||||
|
||||
Reference in New Issue
Block a user