From 6ce5f9a547b8a5ea986b4857ae8adbee7a134627 Mon Sep 17 00:00:00 2001 From: fs Date: Sun, 5 Apr 2026 22:50:28 +0200 Subject: [PATCH] fix(helpdesk): use die() instead of echo for file proxy output MintyPHP Analyzer rejects echo in action files. Use die() which is the same pattern as Router::download() internally. Co-Authored-By: Claude Opus 4.6 (1M context) --- modules/helpdesk/pages/helpdesk/ticket-file-data().php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/helpdesk/pages/helpdesk/ticket-file-data().php b/modules/helpdesk/pages/helpdesk/ticket-file-data().php index 55955b0..1dffb82 100644 --- a/modules/helpdesk/pages/helpdesk/ticket-file-data().php +++ b/modules/helpdesk/pages/helpdesk/ticket-file-data().php @@ -77,9 +77,10 @@ header('Content-Type: ' . $mimeType); header('Content-Disposition: ' . $disposition . '; filename="' . addcslashes($displayFilename, '"\\') . '"'); header('Content-Length: ' . strlen($data)); header('Cache-Control: private, max-age=3600'); +header('Content-Transfer-Encoding: Binary'); while (ob_get_level()) { ob_end_clean(); } -echo $data; +die($data);