From 66be390fa957fb515f681bd2795271b2483ca7e7 Mon Sep 17 00:00:00 2001 From: fs Date: Sun, 5 Apr 2026 22:13:04 +0200 Subject: [PATCH] fix(helpdesk): remove actor from dedup signature to prevent duplicate entries MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SOAP entries often have an empty actor while OData entries have a code like 'NKS'. After name resolution, one becomes 'Nikita Soldatov' and the other stays empty — producing different signatures and causing duplicates. The actor is not a reliable dedup field since the same event can have different actor representations across sources. Dedup now uses: ticket_no + timestamp_iso + type + message_hash. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../lib/Module/Helpdesk/Service/TicketCommunicationService.php | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php b/modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php index 0c85c1e..b946199 100644 --- a/modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php +++ b/modules/helpdesk/lib/Module/Helpdesk/Service/TicketCommunicationService.php @@ -590,7 +590,6 @@ class TicketCommunicationService implode('|', [ (string) ($entry['ticket_no'] ?? ''), (string) ($entry['timestamp_iso'] ?? ''), - (string) ($entry['actor'] ?? ''), (string) ($entry['type'] ?? ''), hash('sha256', (string) ($entry['message'] ?? '')), ])