Refactor helper drift in lib: centralize theme/translation and remove app() hotspots

2026-03-19 08:23:14 +01:00
parent 5da506a20f
commit 5739cc1200
24 changed files with 197 additions and 88 deletions
--- a/lib/Service/User/UserAccountService.php
+++ b/lib/Service/User/UserAccountService.php
@@ -724,12 +724,8 @@ class UserAccountService

    private function normalizeTheme($value): string
    {
-        $theme = strtolower(trim((string) $value));
-        $themes = function_exists('appThemes') ? appThemes() : ['light' => 'Light', 'dark' => 'Dark'];
-        if ($theme === '' || !isset($themes[$theme])) {
-            return function_exists('appDefaultTheme') ? appDefaultTheme() : 'light';
-        }
-        return $theme;
+        $theme = is_scalar($value) ? (string) $value : null;
+        return $this->settingsGateway->normalizeTheme($theme);
    }

    private function normalizeLocale($value): string