Refactor helper drift in lib: centralize theme/translation and remove app() hotspots

2026-03-19 08:23:14 +01:00
parent 5da506a20f
commit 5739cc1200
24 changed files with 197 additions and 88 deletions
--- a/lib/Service/Tenant/TenantService.php
+++ b/lib/Service/Tenant/TenantService.php
@@ -247,8 +247,7 @@ class TenantService
        ) {
            $errors[] = t('Primary color is invalid');
        }
-        $themes = function_exists('appThemes') ? appThemes() : [];
-        if ($form['default_theme'] !== '' && !isset($themes[$form['default_theme']])) {
+        if ($form['default_theme'] !== '' && !$this->settingsGateway->isAllowedTheme((string) $form['default_theme'])) {
            $errors[] = t('Default theme is invalid');
        }
        if (!in_array($form['allow_user_theme_mode'], ['', '0', '1'], true)) {