fa/breadcrumb-the-shire
1
0
Fork 1
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

refactor(audit): remove factory chain and repository interfaces

Browse Source 
Remove AuditRepositoryFactory and AuditServicesFactory — two-layer
factory chain replaced by direct DI container wiring. Delete 4
single-consumer repository interfaces. Register all 4 repositories
and SystemAuditRedactionService directly in container. Update all
service constructors to type-hint concrete classes. Fix architecture
test and documentation references to deleted factories.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Felix Schneider
2026-03-26 12:33:59 +01:00
parent 4bf871b640
commit 570e3923b7
22 changed files with 68 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audit/lib/Module/Audit/Repository/ApiAuditLogRepository.php
View File

@@ -7,7 +7,7 @@ use MintyPHP\Repository\Support\RepoQuery;
use MintyPHP\Repository\Support\RepositoryArrayHelper;
/** Records API request/response audit entries with status codes, timing, and error details. */
class ApiAuditLogRepository implements ApiAuditLogRepositoryInterface
class ApiAuditLogRepository
{
private const FILTER_OPTIONS_LIMIT_MAX = 200;

17
modules/audit/lib/Module/Audit/Repository/ApiAuditLogRepositoryInterface.php
View File

@@ -1,17 +0,0 @@
<?php
namespace MintyPHP\Module\Audit\Repository;
/** Contract for API request audit log creation, pagination, and retention purge. */
interface ApiAuditLogRepositoryInterface
{
public function create(array $data): int|false;
public function listPaged(array $filters): array;
public function listFilterOptions(int $limit = 200): array;
public function find(int $id): ?array;
public function purgeOlderThanDays(int $days): int;
}

2
modules/audit/lib/Module/Audit/Repository/ImportAuditRunRepository.php
View File

@@ -8,7 +8,7 @@ use MintyPHP\Repository\Support\RepoQuery;
use MintyPHP\Repository\Support\RepositoryArrayHelper;
/** Tracks CSV import runs including source file, row counts, status, and completion metadata. */
class ImportAuditRunRepository implements ImportAuditRunRepositoryInterface
class ImportAuditRunRepository
{
private const FILTER_OPTIONS_LIMIT_MAX = 200;

19
modules/audit/lib/Module/Audit/Repository/ImportAuditRunRepositoryInterface.php
View File

@@ -1,19 +0,0 @@
<?php
namespace MintyPHP\Module\Audit\Repository;
/** Contract for CSV import run audit trail creation, completion, and purge. */
interface ImportAuditRunRepositoryInterface
{
public function createRunning(array $data): int|false;
public function finishById(int $id, array $data): bool;
public function listPaged(array $filters): array;
public function listFilterOptions(int $limit = 200): array;
public function find(int $id): ?array;
public function purgeOlderThanDays(int $days): int;
}

2
modules/audit/lib/Module/Audit/Repository/SystemAuditLogRepository.php
View File

@@ -9,7 +9,7 @@ use MintyPHP\Repository\Support\RepoQuery;
use MintyPHP\Repository\Support\RepositoryArrayHelper;
/** Persists system audit events with actor, target, outcome, channel, and hashed request metadata. */
class SystemAuditLogRepository implements SystemAuditLogRepositoryInterface
class SystemAuditLogRepository
{
private const FILTER_OPTIONS_LIMIT_MAX = 200;

17
modules/audit/lib/Module/Audit/Repository/SystemAuditLogRepositoryInterface.php
View File

@@ -1,17 +0,0 @@
<?php
namespace MintyPHP\Module\Audit\Repository;
/** Contract for system-wide security event logging with channel and outcome filtering. */
interface SystemAuditLogRepositoryInterface
{
public function create(array $data): int|false;
public function listPaged(array $filters): array;
public function listFilterOptions(int $limit = 200): array;
public function find(int $id): ?array;
public function purgeOlderThanDays(int $days): int;
}

2
modules/audit/lib/Module/Audit/Repository/UserLifecycleAuditRepository.php
View File

@@ -10,7 +10,7 @@ use MintyPHP\Repository\Support\RepoQuery;
use MintyPHP\Repository\Support\RepositoryArrayHelper;
/** Records user lifecycle transitions (deactivation, deletion, restore) with reason codes and snapshots. */
class UserLifecycleAuditRepository implements UserLifecycleAuditRepositoryInterface
class UserLifecycleAuditRepository
{
private const FILTER_OPTIONS_LIMIT_MAX = 200;

23
modules/audit/lib/Module/Audit/Repository/UserLifecycleAuditRepositoryInterface.php
View File

@@ -1,23 +0,0 @@
<?php
namespace MintyPHP\Module\Audit\Repository;
/** Contract for tracking user deactivation/deletion lifecycle events and restore eligibility. */
interface UserLifecycleAuditRepositoryInterface
{
public function create(array $row): int|false;
public function updateStatus(int $id, string $status, ?string $reasonCode = null): bool;
public function listPaged(array $filters): array;
public function listFilterOptions(int $limit = 200): array;
public function find(int $id): ?array;
public function findDeleteEventForRestore(int $id, bool $forUpdate = false): ?array;
public function markRestored(int $id, int $restoredBy, int $restoredUserId): bool;
public function purgeOlderThanDays(int $days): int;
}